chore: remove react imports #1867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reolves #1856
Kira-Pilot
commented
May 27, 2022
| @@ -114,6 +114,9 @@ rules: | |||
| react/jsx-curly-brace-presence: | |||
| - error | |||
| - children: ignore | |||
| # https://reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html#eslint | |||
| react/jsx-uses-react: "off" | |||
| react/react-in-jsx-scope: "off" | |||
There was a problem hiding this comment.
Turning off these ESLint rules (as suggested by React) so we don't hear it complain.
kylecarbs
approved these changes
May 27, 2022
Kira-Pilot
commented
May 27, 2022
| @@ -5,7 +5,7 @@ | |||
| "forceConsistentCasingInFileNames": true, | |||
| "incremental": true, | |||
| "isolatedModules": true, | |||
| "jsx": "react", | |||
| "jsx": "react-jsx", | |||
There was a problem hiding this comment.
This just informs React that we're using the new transform.
greyscaled
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1856
We no longer need to import React when using JSX.
This is a big change so definitely let me know if you have concerns.
I will comment below on any functional changes to assist in review.