fix(agent/agentcontainers): always derive devcontainer name from workspace folder #18666
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the following Terraform I ran into an issue where devcontainers were named the same. The current strategy for naming devcontainers is overly complex and this change simplifies it by removing one source for them.
While at it, sort order of devcontainers is also made stable by sorting on devcontainer folder rather than name. The previous sorting resulted in devcontainers jumping around in the UI if their name changed.
And this looks wrong in the UI:
And once the devcontainers come up, only one sub-agent can be created. The other will fail due to "name in use" because the implementation in the provisioner assumed this case is not possible.