feat: implement OAuth2 dynamic client registration (RFC 7591/7592) #18645
+5,798
−129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 27, 2025
This was referenced Jun 27, 2025
This was referenced Jun 27, 2025
3902793 to
b37d850
Compare
ff83df4 to
3665807
Compare
b37d850 to
caf974c
Compare
3665807 to
56126dd
Compare
caf974c to
22b8b6d
Compare
56126dd to
fca6b9a
Compare
14c7196 to
c43b551
Compare
fca6b9a to
68baa21
Compare
46d50e8 to
61142ba
Compare
a8a29d4 to
f9e693d
Compare
Looking at the router/ Are you suggesting moving those handlers into a different package or moving the logic behind them into their own package, which then gets called from those API handlers? (I'm assuming the latter, but I want to be sure.) |
3760dd0 to
2a41a65
Compare
9629df1 to
df790c7
Compare
52c88e0 to
4799b4b
Compare
df790c7 to
17af791
Compare
a07ba99 to
5c1b9f6
Compare
17af791 to
3e15358
Compare
5c1b9f6 to
09c5055
Compare
3e15358 to
6bea7a6
Compare
6bea7a6 to
e33d3d6
Compare
… MCP compliance - Add comprehensive OAuth2 dynamic client registration support - Implement RFC 7591 client registration endpoint with proper validation - Implement RFC 7592 client management protocol (GET/PUT/DELETE) - Add RFC 6750 Bearer token authentication support - Fix authorization context issues with AsSystemRestricted - Add proper RBAC permissions for OAuth2 resources - Implement registration access token security per RFC 7592 - Add comprehensive validation for redirect URIs, grant types, response types - Support custom schemes for native applications - Add database migration with all RFC-required fields - Add audit logging support for OAuth2 operations - Ensure full RFC compliance with proper error handling - Add comprehensive test coverage for all scenarios Change-Id: I36c711201d598a117f6bfc381fc74e07fc3cc365 Signed-off-by: Thomas Kosiewski <[email protected]>
e33d3d6 to
4f4e4f1
Compare
This was referenced Jul 3, 2025
|
Alright, so I did the refactoring in two PRs:
The main reason for this two PR approach was to make sure that the refactorings didn't break the tests, and that the test refactoring did not break the code. |
johnstcn
approved these changes
Jul 3, 2025
There was a problem hiding this comment.
nit: the validation tests could probably live in codersdk alongside the func itself but open to it staying here either
Merge activity
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement OAuth2 Dynamic Client Registration (RFC 7591/7592)
This PR implements OAuth2 Dynamic Client Registration according to RFC 7591 and Client Configuration Management according to RFC 7592. These standards allow OAuth2 clients to register themselves programmatically with Coder as an authorization server.
Key changes include:
Added database schema extensions to support RFC 7591/7592 fields in the
oauth2_provider_appstableImplemented
/oauth2/registerendpoint for dynamic client registration (RFC 7591)Added client configuration management endpoints (RFC 7592):
/oauth2/clients/{client_id}Added comprehensive validation for OAuth2 client metadata:
Enhanced developer documentation with:
The implementation follows security best practices from the RFCs, including proper token handling, secure defaults, and appropriate error responses. This enables third-party applications to integrate with Coder's OAuth2 provider capabilities programmatically.