feat(site): display devcontainer start error #18637
Conversation
agent/agentcontainers/api.go
Outdated
| @@ -685,6 +685,8 @@ func (api *API) processUpdatedContainersLocked(ctx context.Context, updated code | |||
| if err != nil { | |||
| logger.Error(ctx, "inject subagent into container failed", slog.Error(err)) | |||
| } | |||
|
|
|||
| dc.Error = err.Error() | |||
There was a problem hiding this comment.
We might want to reset this in some other scenarios as well, like recreate. And assign on recreate error. There’s also the devcontainer status but I don’t think we need to touch it necessarily in this case since it’s an injection error but the devcontainer itself is probably fine.
There was a problem hiding this comment.
@DanielleMaywood did you look into adding this? At present I don't think we surface the error from recreate.
There was a problem hiding this comment.
The current implementation of recreate calls api.RefreshContainers, which should then trigger this (unless I'm mistaken and misreading).
There was a problem hiding this comment.
Not exactly. I’m referring to the error from devcontainer up rather than injection.
There was a problem hiding this comment.
Ah I see now, I'll take a look at fixing that.
There was a problem hiding this comment.
@mafredri I've made that change 👍 Was nice and easy
Fixes coder/internal#705
Surface errors on the UI when a devcontainer agent is unable to be injected.
https://www.chromatic.com/test?appId=624de63c6aacee003aa84340&id=68627f4cdb34c1d90063b7a8
https://www.chromatic.com/test?appId=624de63c6aacee003aa84340&id=68627f4cdb34c1d90063b7a9