feat: add connectionlogs API
#18628
Draft
feat: add connectionlogs API
#18628
+1,917
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 27, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ethanndickson
commented
Jun 27, 2025
|
|
||
| httpapi.Write(ctx, rw, http.StatusOK, codersdk.ConnectionLogResponse{ | ||
| ConnectionLogs: convertConnectionLogs(dblogs), | ||
| Count: 0, // TODO(ethanndickson): Set count |
There was a problem hiding this comment.
This is populated in the next PR in the stack.
8cec6d1 to
482a5d3
Compare
e4e1a04 to
1fcd8d7
Compare
482a5d3 to
ccc7539
Compare
deansheather
reviewed
Jul 2, 2025
Comment on lines
+52
to
+59
| // ConnectionLogStatus is the status of a connection log entry. | ||
| // It's the argument to the `status` filter when fetching connection logs. | ||
| type ConnectionLogStatus string | ||
|
|
||
| const ( | ||
| ConnectionLogStatusConnected ConnectionLogStatus = "connected" | ||
| ConnectionLogStatusDisconnected ConnectionLogStatus = "disconnected" | ||
| ) |
There was a problem hiding this comment.
Only used in the frontend for the UI filter😔
There was a problem hiding this comment.
In that case can you add a comment so it doesn't get removed by accident.
There was a problem hiding this comment.
"This is only used in the frontend, not the backend."
ccc7539 to
406e3f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second PR for moving connection events out of the audit log.
This PR:
/api/v2/connectionlogsendpointGetAuthorizedConnectionLogsOffsetand thus the endpoint.There's quite a few, but I was aiming for feature parity with the audit log.
organization:<id|name>workspace_owner:<username>workspace_owner_email:<email>type:<ssh|vscode|jetbrains|reconnecting_pty|workspace_app|port_forwarding>username:<username>user_email:<email>started_after:<time>started_before:<time>workspace_id:<id>connection_id:<id>status:<connected|disconnected>connectedonly sessions with a nullclose_timeare returned, ifdisconnected, only those with a non-nullclose_time. If filter is omitted, both are returned.Future PRs:
countonConnectionLogResponseusing a seperate query (to preemptively mitigate the issue described in Audit log slows to a crawl when nearing 1 million entries #17689)