fix: use default preset when creating a workspace for task #18623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-asher
approved these changes
Jun 26, 2025
c943a05 to
2ab771c
Compare
It would be great, but in the way we have the fetch calls structured/abstracted right now, it makes testing this quite painful. Since this is going to be a BE endpoint any time soon, I would not invest time on refactoring to make it more testable. Wdyt @code-asher ? |
…build-for-tasks
|
It is merged, but I'm open to add tests in case we find out a good solution for it. |
|
Not even a storybook? |
It already has a storybook 🤔 |
|
For tasks? |
I don't see any mention of presets in that test; am I missing something? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.