-
Notifications
You must be signed in to change notification settings - Fork 928
feat: allow masking workspace parameter inputs #18595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jaaydenh thanks for checking the styles. I think the autofill widget that 1password inserts must've been messing with me. putting the toggle on the outside is a lot more consistent (and doesn't risk covering text content) |
For the eye button, is the intention that it should only show the input when the user clicks and holds the button? Its currently possible to keep the button in a clicked state by clicking and holding on the button dragging the mouse off the button then letting go of the click. This causes the input to remain visible. |
yeah but then if you ever tried to use them in a row or any context where something is positioned to the right of it, it'd throw everything off. if we really wanna discuss the design of it I'd rather just remove the button all together for now and do an actual design round later. |
I think that overall the design regarding the width is low priority as this feature should have limited use. So I would say keep the button for now. |
sounds good. the design could definitely be improved later, I just don't wanna trade one visual oddity for another. 🤷♀️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving but it could still be worth looking into why the eye button remains clicking when clicking on the button then dragging off it before unclicking.
Closes coder/preview#140
Allows you to set
mask_input
on acoder_parameter
to turn it into a "secret" input. Works forform_type
s of"textarea"
and"input"
.