feat: oauth2 - add authorization server metadata endpoint and PKCE support #18548

ThomasK33 · 2025-06-24T18:14:46Z

Summary

This PR implements critical MCP OAuth2 compliance features for Coder's authorization server, adding PKCE support, resource parameter handling, and OAuth2 server metadata discovery. This brings Coder's OAuth2 implementation significantly closer to production readiness for MCP (Model Context Protocol)
integrations.

What's Added

OAuth2 Authorization Server Metadata (RFC 8414)

Add /.well-known/oauth-authorization-server endpoint for automatic client discovery
Returns standardized metadata including supported grant types, response types, and PKCE methods
Essential for MCP client compatibility and OAuth2 standards compliance

PKCE Support (RFC 7636)

Implement Proof Key for Code Exchange with S256 challenge method
Add code_challenge and code_challenge_method parameters to authorization flow
Add code_verifier validation in token exchange
Provides enhanced security for public clients (mobile apps, CLIs)

Resource Parameter Support (RFC 8707)

Add resource parameter to authorization and token endpoints
Store resource URI and bind tokens to specific audiences
Critical for MCP's resource-bound token model

Enhanced OAuth2 Error Handling

Add OAuth2-compliant error responses with proper error codes
Use standard error format: {"error": "code", "error_description": "details"}
Improve error consistency across OAuth2 endpoints

Authorization UI Improvements

Fix authorization flow to use POST-based consent instead of GET redirects
Remove dependency on referer headers for security decisions
Improve CSRF protection with proper state parameter validation

Why This Matters

For MCP Integration: MCP requires OAuth2 authorization servers to support PKCE, resource parameters, and metadata discovery. Without these features, MCP clients cannot securely authenticate with Coder.

For Security: PKCE prevents authorization code interception attacks, especially critical for public clients. Resource binding ensures tokens are only valid for intended services.

For Standards Compliance: These are widely adopted OAuth2 extensions that improve interoperability with modern OAuth2 clients.

Database Changes

Migration 000343: Adds code_challenge, code_challenge_method, resource_uri to oauth2_provider_app_codes
Migration 000343: Adds audience field to oauth2_provider_app_tokens for resource binding
Audit Updates: New OAuth2 fields properly tracked in audit system
Backward Compatibility: All changes maintain compatibility with existing OAuth2 flows

Test Coverage

Comprehensive PKCE test suite in coderd/identityprovider/pkce_test.go
OAuth2 metadata endpoint tests in coderd/oauth2_metadata_test.go
Integration tests covering PKCE + resource parameter combinations
Negative tests for invalid PKCE verifiers and malformed requests

Testing Instructions

# Run the comprehensive OAuth2 test suite
./scripts/oauth2/test-mcp-oauth2.sh

Manual Testing with Interactive Server

# Start Coder in development mode
./scripts/develop.sh

# In another terminal, set up test app and run interactive flow
eval $(./scripts/oauth2/setup-test-app.sh)
./scripts/oauth2/test-manual-flow.sh
# Opens browser with OAuth2 flow, handles callback automatically

# Clean up when done
./scripts/oauth2/cleanup-test-app.sh

Individual Component Testing

# Test metadata endpoint
curl -s http://localhost:3000/.well-known/oauth-authorization-server | jq .

# Test PKCE generation
./scripts/oauth2/generate-pkce.sh

# Run specific test suites
go test -v ./coderd/identityprovider -run TestVerifyPKCE
go test -v ./coderd -run TestOAuth2AuthorizationServerMetadata

Breaking Changes

None. All changes maintain backward compatibility with existing OAuth2 flows.

Change-Id: Ifbd0d9a543d545f9f56ecaa77ff2238542ff954a
Signed-off-by: Thomas Kosiewski [email protected]

ThomasK33 · 2025-06-24T18:15:03Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

johnstcn · 2025-06-26T09:29:48Z

coderd/oauth2.go

-// @Success 302
-// @Router /oauth2/authorize [post]
+// @Success 200 "Returns HTML authorization page"
+// @Router /oauth2/authorize [get]


This looks like a breaking change to me. We should still support the GET /oauth2/authorize -> 302

I'm happy for us to support both methods, but I'd like the existing GET endpoint to behave the same.

The OAuth 2 endpoints were never part of a stable release, only added to the muxer/router in dev builds, so not a breaking change per se.

Thanks for clarifying, I completely missed that!
Confirmed on 2.23 release build.

I think the redirect here would be the spec compliant thing to do, but then I'm a bit too lazy to have to redirect to another page, to do the same thing.

I'm not against it if you think it makes more sense though... just lazy 😅

This were not shipped in a release?

I thought backstage relied on these oauth endpoints?

Nope, you have the OAuth 2 middleware applied to all OAuth 2-related routes, which just returned a status forbidden for non-dev builds.

coder/coderd/oauth2.go

Lines 20 to 31 in 7a3a6d4

func (*API) oAuth2ProviderMiddleware(next http.Handler) http.Handler {

return http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) {

if !buildinfo.IsDev() {

httpapi.Write(r.Context(), rw, http.StatusForbidden, codersdk.Response{

Message: "OAuth2 provider is under development.",

})

return

}

next.ServeHTTP(rw, r)

})

}

coderd/identityprovider/middleware.go

coderd/identityprovider/pkce.go

scripts/oauth2/README.md

Emyrk

Overall things look ok to me 👍

The post to /authorize is a good way to prevent the infinite redirect loop issue. I do not see that in the spec, so it is new to me.

Is there a reason some of the testing lives as bash scripts?

coderd/httpmw/oauth2.go

coderd/identityprovider/identityprovidertest/fixtures.go

coderd/identityprovider/identityprovidertest/helpers.go

coderd/identityprovider/middleware.go

coderd/identityprovider/tokens.go

Emyrk · 2025-06-26T19:01:16Z

coderd/identityprovider/tokens.go

+		if errors.Is(err, errBadSecret) {
+			writeOAuth2Error(ctx, rw, http.StatusUnauthorized, "invalid_client", "The client credentials are invalid")
+			return
+		}
+		if errors.Is(err, errBadCode) {
+			writeOAuth2Error(ctx, rw, http.StatusBadRequest, "invalid_grant", "The authorization code is invalid or expired")
+			return
+		}
+		if errors.Is(err, errInvalidPKCE) {
+			writeOAuth2Error(ctx, rw, http.StatusBadRequest, "invalid_grant", "The PKCE code verifier is invalid")
+			return
+		}
+		if errors.Is(err, errBadToken) {
+			writeOAuth2Error(ctx, rw, http.StatusBadRequest, "invalid_grant", "The refresh token is invalid or expired")
 			return
 		}


This is unfortunate, but I get it.

Emyrk · 2025-06-26T19:02:48Z

coderd/oauth2.go

-// @Success 302
-// @Router /oauth2/authorize [post]
+// @Success 200 "Returns HTML authorization page"
+// @Router /oauth2/authorize [get]


This were not shipped in a release?

I thought backstage relied on these oauth endpoints?

Emyrk · 2025-06-26T19:04:47Z

scripts/oauth2/README.md

+### `setup-test-app.sh`
+
+Creates a test OAuth2 application and outputs environment variables.
+
+Usage:
+
+```bash
+eval $(./scripts/oauth2/setup-test-app.sh)
+echo "Client ID: $CLIENT_ID"
+```
+
+### `cleanup-test-app.sh`
+
+Deletes a test OAuth2 application.
+
+Usage:
+
+```bash
+./scripts/oauth2/cleanup-test-app.sh $CLIENT_ID
+# Or if CLIENT_ID is set as environment variable:
+./scripts/oauth2/cleanup-test-app.sh
+```
+
+### `generate-pkce.sh`
+
+Generates PKCE code verifier and challenge for manual testing.
+
+Usage:
+
+```bash
+./scripts/oauth2/generate-pkce.sh
+```
+
+### `test-manual-flow.sh`
+
+Launches a local Go web server to test the OAuth2 flow interactively. The server automatically handles the OAuth2 callback and token exchange, providing a user-friendly web interface with results.
+
+Usage:
+
+```bash
+# First set up an app
+eval $(./scripts/oauth2/setup-test-app.sh)
+
+# Then run the test server
+./scripts/oauth2/test-manual-flow.sh
+```
+
+Features:
+
+- Starts a local web server on port 9876
+- Automatically captures the authorization code
+- Performs token exchange without manual intervention
+- Displays results in a clean web interface
+- Shows example API calls you can make with the token


Why are these tests in bash? They will not be run in CI then right?

That's right, they won't be run in CI.

They are in Bash because I am testing the actual browser-based flow of a user authorizing and clicking the button on the authorize page. Automating that manual e2e test with something like Puppeteer or other headless browsers seemed a bit overkill to me, at least for now.

Oh there is a browser component to these scripts?

Yeah, it launches a local Go web server that "receives" the authorization code and exchanges it for a coder token after a user clicks on authorize in the browser.

Emyrk · 2025-06-26T19:08:35Z

I'm going to pull copilot in as a reviewer. It's caught some typos in my larger PRs in the past.

Copilot

Pull Request Overview

This PR implements critical OAuth2 features to improve standards compliance in Coder’s authorization server. Key changes include adding a /.well-known/oauth-authorization-server metadata endpoint, full PKCE support within the authorization and token exchange flows, and enhanced handling of the resource parameter for token binding.

Reviewed Changes

Copilot reviewed 40 out of 40 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
site/static/oauth2allow.html	Replaces an anchor link with a POST form for the Allow action to improve security
site/src/api/typesGenerated.ts	Adds the OAuth2AuthorizationServerMetadata type definition for client discovery
scripts/oauth2/*	Introduces extensive test scripts for OAuth2 metadata, PKCE, resource parameter flows, and manual testing
coderd/*	Updates OAuth2 flows, authorization handlers, token exchange logic and introduces PKCE and resource parameter support
enterprise/audit/table.go, docs/*, and others	Updates database models, queries, and documentation to support new OAuth2 fields and behavior

Comments suppressed due to low confidence (3)

coderd/identityprovider/authorize.go:90

[nitpick] Consider adding an inline comment to explain that when a code_challenge is provided but no code_challenge_method is specified, the method defaults to 'S256'. This improves code clarity for future maintainers.

		if params.codeChallenge != "" {

coderd/oauth2_test.go:433

[nitpick] Verify that the error message ‘invalid_client’ is used consistently for client credential failures and aligns with OAuth2 standards. Consistency in error responses will aid clients in correctly interpreting error scenarios.

			tokenError: "invalid_client",

site/static/oauth2allow.html:163

Replacing the anchor link with a POST form for the 'Allow' action enhances security by mitigating CSRF risks. Ensure that the server-side endpoint handling this form validates POST requests appropriately.

        <form method="POST" style="display: inline;">

.

johnstcn

I don't have any blocking comments, deferring approval to @Emyrk

coderd/httpmw/oauth2.go

coderd/identityprovider/authorize.go

coderd/identityprovider/identityprovidertest/helpers.go

coderd/database/migrations/000344_oauth2_extensions.down.sql

Emyrk

This is a big diff. Overall I like the changes, and the structure is good. We can iterate ontop of this.

The bash tests feel a bit weak to me, as I don't think they will be manually run. When these feature stabilizes, we might want to get an e2e test in playwright or something.

…port - Add /.well-known/oauth-authorization-server metadata endpoint (RFC 8414) - Implement PKCE support with S256 method for enhanced security - Add resource parameter support (RFC 8707) for token binding - Add OAuth2-compliant error responses with proper error codes - Fix authorization UI to use POST-based consent instead of GET redirects - Add comprehensive OAuth2 test scripts and interactive test server - Update CLAUDE.md with OAuth2 development guidelines Database changes: - Add migration 000341: code_challenge, resource_uri, audience fields - Update audit table for new OAuth2 fields OAuth2 provider remains development-only (requires --dev flag). Change-Id: Ifbd0d9a543d545f9f56ecaa77ff2238542ff954a Signed-off-by: Thomas Kosiewski <[email protected]>

ThomasK33 · 2025-07-01T13:39:30Z

Merge activity

Jul 1, 1:39 PM UTC: @ThomasK33 merged this pull request with Graphite.

github-actions bot assigned ThomasK33 Jun 24, 2025

ThomasK33 changed the title ~~feat(oauth2): add authorization server metadata endpoint and PKCE support~~ feat: add authorization server metadata endpoint and PKCE support Jun 24, 2025

ThomasK33 force-pushed the thomask33/06-24-feat_oauth2_add_authorization_server_metadata_endpoint_and_pkce_support branch 8 times, most recently from 8f890ec to 018694a Compare June 25, 2025 13:59

ThomasK33 mentioned this pull request Jun 25, 2025

feat: oauth2 - add RFC 8707 resource indicators and audience validation #18575

Open

ThomasK33 force-pushed the thomask33/06-24-feat_oauth2_add_authorization_server_metadata_endpoint_and_pkce_support branch from 018694a to 3daa2ab Compare June 25, 2025 14:06

ThomasK33 marked this pull request as ready for review June 25, 2025 14:07

ThomasK33 changed the title ~~feat: add authorization server metadata endpoint and PKCE support~~ feat: oauth2 - add authorization server metadata endpoint and PKCE support Jun 25, 2025

ThomasK33 requested review from Emyrk and johnstcn June 25, 2025 14:21

ThomasK33 force-pushed the thomask33/06-24-feat_oauth2_add_authorization_server_metadata_endpoint_and_pkce_support branch from 3daa2ab to b50e322 Compare June 25, 2025 18:16

johnstcn previously requested changes Jun 26, 2025

View reviewed changes

ThomasK33 force-pushed the thomask33/06-24-feat_oauth2_add_authorization_server_metadata_endpoint_and_pkce_support branch 2 times, most recently from 3dd6c7e to 224784a Compare June 26, 2025 15:45

ThomasK33 changed the base branch from main to graphite-base/18548 June 26, 2025 16:20

ThomasK33 force-pushed the thomask33/06-24-feat_oauth2_add_authorization_server_metadata_endpoint_and_pkce_support branch from 224784a to c2d85d9 Compare June 26, 2025 16:20

ThomasK33 changed the base branch from graphite-base/18548 to thomask33/fix_pin_Nix_version_to_2.28.4_to_avoid_JSON_type_error June 26, 2025 16:20

ThomasK33 mentioned this pull request Jun 26, 2025

fix: pin Nix version to 2.28.4 to avoid JSON type error #18612

Merged

ThomasK33 force-pushed the thomask33/06-24-feat_oauth2_add_authorization_server_metadata_endpoint_and_pkce_support branch from c2d85d9 to 69eb5c8 Compare June 26, 2025 16:23

ThomasK33 force-pushed the thomask33/fix_pin_Nix_version_to_2.28.4_to_avoid_JSON_type_error branch from ce6aacd to 0efb35b Compare June 26, 2025 16:23

ThomasK33 force-pushed the thomask33/06-24-feat_oauth2_add_authorization_server_metadata_endpoint_and_pkce_support branch from 69eb5c8 to 80c695b Compare June 26, 2025 16:24

ThomasK33 force-pushed the thomask33/fix_pin_Nix_version_to_2.28.4_to_avoid_JSON_type_error branch from 0efb35b to 0218619 Compare June 26, 2025 16:24

graphite-app bot changed the base branch from graphite-base/18548 to main June 26, 2025 16:34

ThomasK33 force-pushed the thomask33/06-24-feat_oauth2_add_authorization_server_metadata_endpoint_and_pkce_support branch 2 times, most recently from 870e5eb to dd622d0 Compare June 26, 2025 17:00

ThomasK33 mentioned this pull request Jun 26, 2025

docs: add Go LSP MCP configs and tools guide for code navigation #18613

Open

Emyrk reviewed Jun 26, 2025

View reviewed changes

Emyrk requested a review from Copilot June 26, 2025 19:08

Copilot AI reviewed Jun 26, 2025

View reviewed changes

ThomasK33 force-pushed the thomask33/06-24-feat_oauth2_add_authorization_server_metadata_endpoint_and_pkce_support branch from dd622d0 to 3092108 Compare June 27, 2025 17:29

johnstcn reviewed Jun 30, 2025

View reviewed changes

ThomasK33 force-pushed the thomask33/06-24-feat_oauth2_add_authorization_server_metadata_endpoint_and_pkce_support branch 3 times, most recently from 0cb471e to f211bdd Compare June 30, 2025 11:49

Emyrk approved these changes Jun 30, 2025

View reviewed changes

This was referenced Jun 30, 2025

fix: remove unique constraint on OAuth2 provider app names #18669

Open

feat: add MCP HTTP transport endpoint with authentication #18670

Open

ThomasK33 force-pushed the thomask33/06-24-feat_oauth2_add_authorization_server_metadata_endpoint_and_pkce_support branch 2 times, most recently from a9550d8 to ec5c703 Compare July 1, 2025 09:27

ThomasK33 force-pushed the thomask33/06-24-feat_oauth2_add_authorization_server_metadata_endpoint_and_pkce_support branch from ec5c703 to e6243ce Compare July 1, 2025 13:23

ThomasK33 mentioned this pull request Jul 1, 2025

feat: add OAuth2 provider functionality as an experiment #18692

Open

ThomasK33 merged commit 6f2834f into main Jul 1, 2025
41 of 42 checks passed

ThomasK33 deleted the thomask33/06-24-feat_oauth2_add_authorization_server_metadata_endpoint_and_pkce_support branch July 1, 2025 13:39

github-actions bot locked and limited conversation to collaborators Jul 1, 2025

	func (*API) oAuth2ProviderMiddleware(next http.Handler) http.Handler {
	return http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) {
	if !buildinfo.IsDev() {
	httpapi.Write(r.Context(), rw, http.StatusForbidden, codersdk.Response{
	Message: "OAuth2 provider is under development.",
	})
	return
	}

	next.ServeHTTP(rw, r)
	})
	}

feat: oauth2 - add authorization server metadata endpoint and PKCE support #18548

feat: oauth2 - add authorization server metadata endpoint and PKCE support #18548

Conversation

ThomasK33 commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

What's Added

OAuth2 Authorization Server Metadata (RFC 8414)

PKCE Support (RFC 7636)

Resource Parameter Support (RFC 8707)

Enhanced OAuth2 Error Handling

Authorization UI Improvements

Why This Matters

Database Changes

Test Coverage

Testing Instructions

Breaking Changes

Uh oh!

ThomasK33 commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Emyrk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Emyrk commented Jun 26, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

johnstcn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Emyrk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ThomasK33 commented Jul 1, 2025

Merge activity

Uh oh!

Uh oh!

ThomasK33 commented Jun 24, 2025 •

edited

Loading

ThomasK33 commented Jun 24, 2025 •

edited

Loading