Skip to content

fix: add fallback icons for notifications #17013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 28, 2025
Merged

fix: add fallback icons for notifications #17013

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f9662a8
work on fallback icons
defelmnq Mar 20, 2025
f2c57f4
merge with main
defelmnq Mar 26, 2025
033d78a
add tests for fallback
defelmnq Mar 26, 2025
a633e8e
Merge remote-tracking branch 'origin/main' into notif-inbox/internal-522
defelmnq Mar 27, 2025
0469e57
add tests and improve fallback logic
defelmnq Mar 27, 2025
d22f0b5
improve tests
defelmnq Mar 27, 2025
4c4527c
improve testings on icons
defelmnq Mar 28, 2025
783b04b
improve testings on icons
defelmnq Mar 28, 2025
3ac9d92
nit changes
defelmnq Mar 28, 2025
0b2496e
nit changes
defelmnq Mar 28, 2025
dc38924
Merge branch 'main' into notif-inbox/internal-522
defelmnq Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
improve tests
  • Loading branch information
@defelmnq
defelmnq committed Mar 27, 2025
commit d22f0b56e23a88ef4ad285e33987e1a563f89cdc
28 changes: 17 additions & 11 deletions coderd/inboxnotifications_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -869,6 +869,8 @@ func TestInboxNotifications_MarkAllAsRead(t *testing.T) {
}

func TestInboxNotifications_SetInboxNotificationIcon(t *testing.T) {
t.Parallel()

tests := []struct {
name string
icon string
Expand Down Expand Up @@ -913,17 +915,21 @@ func TestInboxNotifications_SetInboxNotificationIcon(t *testing.T) {
for _, tt := range tests {
tt := tt

notif := codersdk.InboxNotification{
ID: uuid.New(),
UserID: uuid.New(),
TemplateID: tt.templateID,
Title: "notification title",
Content: "notification content",
Icon: tt.icon,
CreatedAt: time.Now(),
}
t.Run(tt.name, func(t *testing.T) {
t.Parallel()

coderd.SetInboxNotificationIcon(&notif)
require.Equal(t, tt.expectedIcon, notif.Icon)
notif := codersdk.InboxNotification{
ID: uuid.New(),
UserID: uuid.New(),
TemplateID: tt.templateID,
Title: "notification title",
Content: "notification content",
Icon: tt.icon,
CreatedAt: time.Now(),
}

coderd.SetInboxNotificationIcon(&notif)
require.Equal(t, tt.expectedIcon, notif.Icon)
})
}
}
Loading