refactor: Update create workspace flow to allow creation from the workspaces page #1684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greyscaled
reviewed
May 23, 2022
| @@ -35,7 +35,7 @@ export const FormFooter: React.FC<FormFooterProps> = ({ | |||
| const styles = useStyles() | |||
| return ( | |||
| <div className={styles.footer}> | |||
| <Button className={styles.button} onClick={onCancel} variant="outlined"> | |||
| <Button type="button" className={styles.button} onClick={onCancel} variant="outlined"> | |||
There was a problem hiding this comment.
Question(blocking): Why is type="button" needed here -- is it causing accidental submit ?
There was a problem hiding this comment.
By default, any button inside a form submits the form. I thought MUI would add the type="button" automatically but it does not so I have to explicitly say type="button".
Kira-Pilot
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1638
PS: This is only about the flow, a major "redesign" will come in a next PR.