Skip to content

feat: Implement RBAC checks on /templates endpoints #1678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 24, 2022

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented May 23, 2022

  • Add generic AuthorizeFilter for db types

@Emyrk Emyrk marked this pull request as ready for review May 23, 2022 20:14
Emyrk added 2 commits May 23, 2022 15:55
- Use new authorize filter on other endpoints
- Pass in objs vs making RBACObjects
@Emyrk Emyrk requested review from kylecarbs, f0ssel and spikecurtis May 23, 2022 21:36
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to my eyes, some minor comments 👍

@Emyrk Emyrk merged commit c7ca86d into main May 24, 2022
@Emyrk Emyrk deleted the stevenmasley/rbac_templates branch May 24, 2022 13:43
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
* feat: Generic Filter method for rbac objects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants