Skip to content

ci: set xcode sdk version when building dylib #16466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Feb 6, 2025

The Coder Desktop app might not be able to load the dylib because the hardened runtime version is different. Right now, without manually selecting an XCode version, the dylib is built with hardened runtime version 14.5. The macOS app & system extension is built with the XCode 16 SDK, which uses version 15.0.

i.e.

$ sudo codesign -dvvv /Applications/Coder\ Desktop.app/Contents/Library/SystemExtensions/com.coder.Coder-Desktop.VPN.systemextension/
Runtime Version=15.0.0
$ sudo codesign -dvvv /var/root/Library/Containers/com.coder.Coder-Desktop.VPN/Data/Documents/coder-vpn.dylib
Runtime Version=14.5.0

Even if this isn't an issue, I think it's preferable to select a specific xcode version here to avoid things breaking from under us.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main or release branch
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@ethanndickson ethanndickson marked this pull request as ready for review February 6, 2025 05:58
@ethanndickson ethanndickson enabled auto-merge (squash) February 6, 2025 05:58
@ethanndickson ethanndickson merged commit 3a884df into main Feb 6, 2025
46 checks passed
@ethanndickson ethanndickson deleted the ethan/switch-xcode-sdk-dylib branch February 6, 2025 06:05
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant