Skip to content

fix: use unique workspace owners over unique users #11044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 7, 2023
Merged

Conversation

f0ssel
Copy link
Contributor

@f0ssel f0ssel commented Dec 5, 2023

Closes #10820

Currently the active_user_count on each template is not really "active users" but the count of any user that has made a workspace that was healthy based on the template.

This changes it to use the count of unique workspace owners based off the template, which I believe is what users will expect the number to be based on the issue made for this.

@f0ssel f0ssel closed this Dec 5, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
@f0ssel f0ssel reopened this Dec 6, 2023
@f0ssel f0ssel changed the title fix: use template daus over unique users fix: use unique workspace owners over unique users Dec 6, 2023
@f0ssel f0ssel marked this pull request as ready for review December 6, 2023 16:22
@f0ssel f0ssel requested a review from deansheather December 7, 2023 15:09
Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 The original value is still there too if you want to pull the total ever. Reading the issue ticket, this all makes sense.

@f0ssel
Copy link
Contributor Author

f0ssel commented Dec 7, 2023

Yeah I have a feeling people will want to know the total unique users that have ever used the template somewhere in the UI so I wanted to leave it for now.

@f0ssel f0ssel merged commit 8aea604 into main Dec 7, 2023
@f0ssel f0ssel deleted the f0ssel/template-daus branch December 7, 2023 15:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Used by in templates list is innacurate
3 participants