fix: Broken links (SEO agency) #20928
Conversation
Updated broken links on overview page.
Fixed broken link.
|
🚀 HackerNews Cloud UI deployed to Vercel: You can also check out this plugin in action at: Unique Vercel deployment URL: |
|
🚀 MySQL Cloud UI deployed to Vercel: |
|
🚀 XKCD Cloud UI deployed to Vercel: |
Co-authored-by: Erez Rokah <[email protected]>
Co-authored-by: Erez Rokah <[email protected]>
| @@ -1,4 +1,4 @@ | |||
| The Hacker News Source plugin for CloudQuery extracts configuration from the [Hacker News API](https://github.com/HackerNews/API) and loads it into any supported CloudQuery destination (e.g. PostgreSQL, BigQuery, Snowflake, and [more](/docs/plugins/destinations/overview)). | |||
There was a problem hiding this comment.
I think we want to keep the relative link here /docs/plugins/destinations/overview.
See https://hub.cloudquery.io/plugins/source/cloudquery/hackernews/latest/docs
Since the link is relative, when you click more it opens in the same tab. If you'd use the full path it will open in a new table.
Also full paths won't work in Vercel deploy previews (they'll always point to the main deploy instead of the preview deploy)
There was a problem hiding this comment.
Cool. Does that definitely land in the right place though?
http://cloudquery.io/docs/plugins/destinations/overview currently goes to https://docs.cloudquery.io/docs/plugins/destinations/overview - is that what would happen when deployed?
There was a problem hiding this comment.
In plugins docs the path would be relative to the Hub so. We map it from /docs/plugins/destinations/overview to /plugins/destination so it will end up as https://hub.cloudquery.io/plugins/destination
The mapping is done for compatibility reasons https://github.com/cloudquery/frontend/blob/f4fe12059928dbcc2de64a65a3b87b92089d75bc/apps/hub/src/components/plugin/sections/documentation/utils/index.tsx#L53 here (docs are versioned so old versions have the old links)
We could change it to /plugins/destination and it should work the same I think
Summary
Fixed a number of broken links in plugin documentation