test: Add test that simulates multiple concurrent syncs #20907
+205
−80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 ClickHouse Cloud UI deployed to Vercel: |
4f17884 to
6778728
Compare
6778728 to
56298c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a test for an issue that's more evident on older ClickHouse versions (e.g. 22 that we don't support anymore) where
max_concurrent_queriesdefaulted to100.The result of hitting the limit is that some tables can be dropped unexpectedly, since
checkPartitionOrOrderByChangedcalled fromcheckForcedherecloudquery/plugins/destination/clickhouse/client/migrate.go
Line 31 in a69aa8c
checkPartitionOrOrderByChangedcan return an error when called further down the line herecloudquery/plugins/destination/clickhouse/client/migrate.go
Line 149 in a69aa8c
Opening for reference. Will add a fix for the issue in this PR as well.
Had to override the
max_concurrent_queriesconfiguration so using the docker compose file for that