Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Code Easier to Follow #15

Open
bshaffer opened this issue May 10, 2013 · 3 comments
Open

Make Code Easier to Follow #15

bshaffer opened this issue May 10, 2013 · 3 comments

Comments

@bshaffer
Copy link
Owner

Lots of people get pointed here, but how is it to understand what's going on unless you have an understanding of silex?

The ansewr is... very hard!!. This is suppsed to be simple, so give these people a break!
@bshaffer
Copy link
Owner Author

  • Change LockdIn to OAuth2_Server
  • Change Demo to OAuth2_Client
  • refactor index.php into something more intuitive
  • refactor Controller Provider into something more intuitive

@bshaffer
Copy link
Owner Author

All of these have been completed in 6d8b8c0

@bshaffer
Copy link
Owner Author

Some new ideas:

  • Rename Client.php and Server.php to Routing.php, as all these do is declare the routes for the controller classes
  • Get rid of addRoutes on controller classes, and have this done by the routing classes
  • Find a home in Shared for the configuration logic currently in index.php
  • Find a better home for where the OAuth2 server is set up... currently in Server.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bshaffer