Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support CNAME adblocking #11712

Closed
antonok-edm opened this issue Sep 14, 2020 · 2 comments · Fixed by brave/brave-core#6640
Closed

Support CNAME adblocking #11712

antonok-edm opened this issue Sep 14, 2020 · 2 comments · Fixed by brave/brave-core#6640
Assignees
@antonok-edm
Labels
enhancement feature/shields/adblock Blocking ads & trackers with Shields OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.17.x - Release #1

Comments

@antonok-edm
Copy link
Collaborator

The API described in #7117 is primarily used by extensions to block resources that served from many different domains to circumvent traditional adblocking techniques. Similarly, Brave's most important use-case for the DNS resolution API is to integrate it with Shields.

Shields should block any network requests where either the original URL or that URL's canonical name (DNS CNAME record) matches any adblock rules.

Since our network blocking is done in C++ code, this doesn't necessarily need to be exposed as a Javascript API.
@antonok-edm antonok-edm added enhancement feature/shields/adblock Blocking ads & trackers with Shields OS/Android Fixes related to Android browser functionality OS/Desktop labels Sep 14, 2020
@antonok-edm antonok-edm self-assigned this Sep 14, 2020
@antonok-edm antonok-edm mentioned this issue Sep 14, 2020
Merged
32 tasks
@ryanbr ryanbr mentioned this issue Sep 24, 2020
Open
@antonok-edm antonok-edm added this to the 1.17.x - Nightly milestone Oct 14, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Nov 9, 2020 •
edited by btlechowski
Loading

Verified passed with

Brave | 1.17.63 Chromium: 87.0.4280.49 (Official Build) unknown (x86_64)
-- | --
Revision | f77f85899646b42a1d3c8ff36794e00becab9171-refs/branch-heads/4280@{#1115}
OS | macOS Version 10.14.6 (Build 18G6032)

Verified test plan from brave/brave-core#6640. Confirmed https://xxxx.mathon.fr/xxxxxxxxxxx.js listed in shields with above build. Confirmed https://static.criteo.net/js/ld/ld.js is not listed in shields on Network tab of Dev Tools.

Screenshots Screen Shot 2020-11-09 at 7 08 43 AM Screen Shot 2020-11-09 at 7 10 20 AM

Verified passed with

Brave 1.17.63 Chromium: 87.0.4280.49 (Official Build) dev (64-bit)
Revision f77f85899646b42a1d3c8ff36794e00becab9171-refs/branch-heads/4280@{#1115}
OS Windows 7 Service Pack 1 (Build 7601.24544)

Verified test plan from brave/brave-core#6640. Confirmed https://xxxx.mathon.fr/xxxxxxxxxxx.js listed in shields with above build. Confirmed https://static.criteo.net/js/ld/ld.js is not listed in shields on Network tab of Dev Tools.

Screenshots

image
image

Verification passed on

Brave 1.17.63 Chromium: 87.0.4280.49 (Official Build) dev (64-bit)
Revision f77f85899646b42a1d3c8ff36794e00becab9171-refs/branch-heads/4280@{#1115}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#6640. Confirmed https://xxxx.mathon.fr/xxxxxxxxxxx.js listed in shields with above build. Confirmed https://static.criteo.net/js/ld/ld.js is not listed in shields on Network tab of Dev Tools.

Screenshots ![image](https://user-images.githubusercontent.com/34715963/98609773-66f7aa80-22ee-11eb-9ff6-0821f5e5329e.png) ![image](https://user-images.githubusercontent.com/34715963/98609784-6c54f500-22ee-11eb-9832-65e18a911c92.png)

@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.17.66 x64 beta build

  • Verified https://xxxx.mathon.fr/xxxxxxxx.js is blocked
  • Verified https://static.criteo.net/js/ld/ld.js is not listed
    image

Verification passed on Samsung Tab A with Android 10 running 1.17.66 x64 beta build

  • Verified https://xxxx.mathon.fr/xxxxxxxx.js is blocked
  • Verified https://static.criteo.net/js/ld/ld.js is not listed
    image

@LaurenWags LaurenWags mentioned this issue Nov 18, 2020
Closed
@kjozwiak kjozwiak mentioned this issue Nov 27, 2020
Closed
@Dev-i-l Dev-i-l mentioned this issue Dec 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antonok-edm antonok-edm

Labels
enhancement feature/shields/adblock Blocking ads & trackers with Shields OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.17.x - Release #1
Development

Successfully merging a pull request may close this issue.

Support CNAME adblocking brave/brave-core
4 participants
@srirambv @antonok-edm @LaurenWags @btlechowski