Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that users should force composer to create composer.json file when using a new vendor-bin namespace #30

Closed
Ayesh opened this issue Sep 3, 2017 · 5 comments
Closed

Document that users should force composer to create composer.json file when using a new vendor-bin namespace #30

Ayesh opened this issue Sep 3, 2017 · 5 comments

Comments

@Ayesh
Copy link
Contributor

Ayesh commented Sep 3, 2017

Hi Bilal,
Thanks for this awesome plugin. I use it in all my computers and helped immensely to organize my global composer packages.

When we run composer bin example, composer changes the directory to vendor-bin/example, and executes the command specified next. Composer 1.5.1 came with a new feature that it checks scans the directories upwards until it finds a composer.json file if the current directory does not contain a composer.json file.

User is prompted of course, and the default value is set so that composer is allowed to use the root level composer.json file. Can we update the README.txt of this project to indicate that users wishing to install something in a new vendor-bin namespace should answer No?

Thanks.
@Ayesh
Copy link
Contributor Author

Ayesh commented Sep 3, 2017 •
edited

cc

@theofidry
Copy link
Collaborator

I'm 👍 for the message. @Ayesh do you mind opening a PR for it?

It would be cool however if we could completely disable that question as in the case of that plugin, it makes no sense at all.

@Ayesh
Copy link
Contributor Author

Ayesh commented Sep 3, 2017

@theofidry thanks!
I don't really know much about the Composer inner APIs, but there is an option (-d / --working-dir=)to explicitly set the working directory to whatever directory we want. Perhaps this plugin can enforce this... I will see what I can pull off.

This was referenced Sep 3, 2017
Closed
Merged
@bamarni
Copy link
Owner

bamarni commented Sep 4, 2017

Thanks, the fix LGTM. Hopefully your PR upstream gets accepted.

@Ayesh
Copy link
Contributor Author

Ayesh commented Sep 11, 2017

Composer PR was just accepted!

@bamarni bamarni closed this as completed Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Ayesh @bamarni @theofidry