Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow defining the bin dependencies in the main package.json #28

Closed
jtojnar opened this issue Jun 25, 2017 · 1 comment
Closed

Allow defining the bin dependencies in the main package.json #28

jtojnar opened this issue Jun 25, 2017 · 1 comment

Comments

@jtojnar
Copy link
Contributor

jtojnar commented Jun 25, 2017

If all developer wants is to install one bin dependency per namespace, creating the separate package.json file for each of them feels like an overkill.

How do you feel about adding the following sugar?

{
    "extra": {
        "bamarni-bin": {
            "packages": {
                "cs": {
                    "friendsofphp/php-cs-fixer": "^2.3"
                },
                "lint": {
                    "jakub-onderka/php-parallel-lint": "^0.9.2"
                },
                "phpstan": {
                    "phpstan/phpstan": "^0.7.0",
                    "phpstan/phpstan-nette": "^0.7.0"
                }
            }
        }
    }
}
@bamarni
Copy link
Owner

bamarni commented Jun 28, 2017

The current implementation implies that the plugin doesn't know anything about dependencies, it's basically just a helper proxy command that'll run in a sub composer project, similar to "composer global".

As such, there is unfortunately no way to have this kind of sugar without making drastic refactoring. And I'd like to keep the plugin simple.

@bamarni bamarni closed this as completed Jul 6, 2017
@bamarni bamarni mentioned this issue Sep 10, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jtojnar @bamarni