Bug fix/improve visualizer performance #21819
Conversation
…r the graph visualizer
| var tooltipText = ""; | ||
|
|
||
| if (config.nodeLabel) { | ||
| // Original behavior: treat nodeLabel as a single attribute name, not space-separated |
There was a problem hiding this comment.
I think we did have support for space-separated nodeLabel, but it's not in the docs
So it I think we can drop it. But maybe we should specify that we are doing so in this comment? @mchacki
current arangodb behaviour (treats nodeLabel as space-separated):
post this PR (treats it as a single attribute):
There was a problem hiding this comment.
On reading again, I think that's what the "Original behaviour" comment is supposed to mean; maybe we can just clarify we are changing the behaviour 😄
Also we can specify the same here, that's where I first came across it: https://github.com/arangodb/arangodb/pull/21819/files#diff-7d765630af3b95a6a824eb4f5446989c17a6ef61e4b0692949d50aea600f6ec0R1110
Co-authored-by: Vadim Kondratev <[email protected]>
|
@palashkaria Thank you for the review. (sorry I did some rebase with devel and I am not sure if "review since last viewed" will still work for you. |
|
Looks good, tested the node label changes again, and works fine now! Found another small change while testing -
Again a small one, but we probably didn't intend to make this change @mchacki |
Scope & Purpose
Refactored the backend for graph visualizer and improved the underlying queries. Also added a new test file for the endpoint. I did run the test file against a devel version before this change.
Checklist
Related Information
(Please reference tickets / specification / other PRs etc)