Fix load memory order #21818
Merged
Fix load memory order #21818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbajic
approved these changes
Jun 23, 2025
maierlars
approved these changes
Jun 24, 2025
mchacki
pushed a commit
that referenced
this pull request
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the load memory order in the ThreadOwnedList which is used in the async registry. Using
memory_order_releasefor a load operation does not make sense and can lead to compiler or runtime errors. Unfortunately, the combination of clang and libstdc++ does not seem to catch this error during compilation.This wrong memory order usage can lead to a data race in the async registry but which is not really relevant: this data race can happen when we run the garbage collection on the async registry which can lead to an entry in the async registry not beeing deleted. But the garbage collection runs regularly, per default every second, so in the next run the item can the be deleted properly.
This is most likely the issue leading to #21811.