Add AQL query recording. #21816
Merged
Add AQL query recording. #21816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbajic
reviewed
Jun 26, 2025
tests/js/client/shell/recording.js
Outdated
| // API should exist, but might be disabled or require different permissions | ||
| // We accept both success (200) and forbidden (403) as valid responses | ||
| // indicating the endpoint exists | ||
| assertTrue(doc.code === 200 || doc.code === 403 || doc.code === 404, |
There was a problem hiding this comment.
Why do we also accept 404, shouldn't that be an error since api was not found?
Suggested change
| assertTrue(doc.code === 200 || doc.code === 403 || doc.code === 404, | |
| assertTrue(doc.code === 200 || doc.code === 403 || doc.code === 404, |
There was a problem hiding this comment.
Done, I now only accept 200. This is just some LLM halluzination, which I did not catch.
| @@ -328,3 +353,58 @@ void RestAdminServerHandler::handleApiCalls() { | |||
| } | |||
| generateOk(rest::ResponseCode::OK, builder.slice()); | |||
| } | |||
|
|
|||
| void RestAdminServerHandler::handleAqlQueries() { | |||
There was a problem hiding this comment.
I would expect this to be named something like handleAqlRecordingQueries
jbajic
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds AQL query recording on a per server level.
This uses the same mechanisms as the API call recording.
A new API is exposed to deliver the recently executed queries.
This API should only be executable with admin access. There is a
config setting to restrict it to superuser or to switch it off in its
entirety.
Scope & Purpose
(Please describe the changes in this PR for reviewers, motivation, rationale - mandatory)
Checklist