Skip to content

FE-611 | Add Vector Index Feature #21793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Jun 25, 2025

Conversation

bluepal-nadeem-abdun
Copy link
Contributor

@bluepal-nadeem-abdun bluepal-nadeem-abdun commented Jun 2, 2025

Scope & Purpose

  • ✨ Feature

Adds support for the new experimental vector index to the collection Indexes view in the core DB UI. The index appears as "Vector index (beta)" in the dropdown, and is only shown when the server is started with the --experimental-vector-index flag.

Checklist

  • Tests
    • Manually tested
  • 📖 CHANGELOG entry made

Related Information

cmyk47
cmyk47 previously requested changes Jun 2, 2025
KVS85
KVS85 previously requested changes Jun 5, 2025
@cmyk47 cmyk47 dismissed their stale review June 6, 2025 07:18

fixed

Copy link
Contributor

@Simran-B Simran-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The vector index supports the following options (not persisted / returned by the server), similar to other index types:

  • inBackground (see below)
  • parallelism: The number of threads to use for indexing. The default is 2.

The only other index with a parallelism option seems to be the inverted index but we don't display it in the UI - I'm not sure if this is a conscience decision or not. I believe we found that 2 is a bit faster than 1 but any larger number were performing worse than 2, so there is little point in changing it for the inverted index. It could be very different for the vector index, though.

I noticed that e.g. for the persistent index, we don't have a particularly useful tooltip for Create in background:

image

My suggestion is to change it everywhere to something like this:

Enable this option to keep the collection/shards available for write operations by not using an exclusive write lock for the duration of the index creation.

Copy link
Contributor

@palashkaria palashkaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bluepal-nadeem-abdun bluepal-nadeem-abdun dismissed stale reviews from KVS85 and Simran-B June 17, 2025 07:55

Confirmed with the jira reporter and it was suggested that the label should be "beta".

@bluepal-nadeem-abdun bluepal-nadeem-abdun requested review from Simran-B, shd8 and KVS85 and removed request for KVS85, Simran-B and shd8 June 17, 2025 07:57
@palashkaria palashkaria merged commit 96c5460 into devel Jun 25, 2025
1 of 2 checks passed
@palashkaria palashkaria deleted the feature/FE-611/add-new-vector-index-ui branch June 25, 2025 10:01
mchacki pushed a commit that referenced this pull request Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants