-
Notifications
You must be signed in to change notification settings - Fork 853
FE-611 | Add Vector Index Feature #21793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...ps/system/_admin/aardvark/APP/react/src/views/collections/indices/useSupportedIndexTypes.tsx
Outdated
Show resolved
Hide resolved
.../system/_admin/aardvark/APP/react/src/views/collections/indices/CollectionIndicesContext.tsx
Outdated
Show resolved
Hide resolved
...pps/system/_admin/aardvark/APP/react/src/views/collections/indices/addIndex/AddIndexForm.tsx
Outdated
Show resolved
Hide resolved
...pps/system/_admin/aardvark/APP/react/src/views/collections/indices/addIndex/AddIndexForm.tsx
Outdated
Show resolved
Hide resolved
...ps/system/_admin/aardvark/APP/react/src/views/collections/indices/useSupportedIndexTypes.tsx
Outdated
Show resolved
Hide resolved
…ture/FE-611/add-new-vector-index-ui
...ps/system/_admin/aardvark/APP/react/src/views/collections/indices/useSupportedIndexTypes.tsx
Show resolved
Hide resolved
…ture/FE-611/add-new-vector-index-ui
...ardvark/APP/react/src/views/collections/indices/addIndex/vectorIndex/useCreateVectorIndex.ts
Outdated
Show resolved
Hide resolved
...ardvark/APP/react/src/views/collections/indices/addIndex/vectorIndex/useCreateVectorIndex.ts
Outdated
Show resolved
Hide resolved
...ardvark/APP/react/src/views/collections/indices/addIndex/vectorIndex/useCreateVectorIndex.ts
Outdated
Show resolved
Hide resolved
...ardvark/APP/react/src/views/collections/indices/addIndex/vectorIndex/useCreateVectorIndex.ts
Show resolved
Hide resolved
...ardvark/APP/react/src/views/collections/indices/addIndex/vectorIndex/useCreateVectorIndex.ts
Outdated
Show resolved
Hide resolved
...ardvark/APP/react/src/views/collections/indices/addIndex/vectorIndex/useCreateVectorIndex.ts
Outdated
Show resolved
Hide resolved
…ture/FE-611/add-new-vector-index-ui
...ardvark/APP/react/src/views/collections/indices/addIndex/vectorIndex/useCreateVectorIndex.ts
Outdated
Show resolved
Hide resolved
...ardvark/APP/react/src/views/collections/indices/addIndex/vectorIndex/useCreateVectorIndex.ts
Outdated
Show resolved
Hide resolved
...ardvark/APP/react/src/views/collections/indices/addIndex/vectorIndex/useCreateVectorIndex.ts
Outdated
Show resolved
Hide resolved
...ardvark/APP/react/src/views/collections/indices/addIndex/vectorIndex/useCreateVectorIndex.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The vector index supports the following options (not persisted / returned by the server), similar to other index types:
inBackground
(see below)parallelism
: The number of threads to use for indexing. The default is2
.
The only other index with a parallelism
option seems to be the inverted index but we don't display it in the UI - I'm not sure if this is a conscience decision or not. I believe we found that 2 is a bit faster than 1 but any larger number were performing worse than 2, so there is little point in changing it for the inverted index. It could be very different for the vector index, though.
I noticed that e.g. for the persistent index, we don't have a particularly useful tooltip for Create in background:
My suggestion is to change it everywhere to something like this:
Enable this option to keep the collection/shards available for write operations by not using an exclusive write lock for the duration of the index creation.
…ture/FE-611/add-new-vector-index-ui
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Confirmed with the jira reporter and it was suggested that the label should be "beta".
…ture/FE-611/add-new-vector-index-ui
…ew-vector-index-ui # Conflicts: # CHANGELOG
Scope & Purpose
Adds support for the new experimental vector index to the collection Indexes view in the core DB UI. The index appears as
"Vector index (beta)"
in the dropdown, and is only shown when the server is started with the--experimental-vector-index
flag.Checklist
Related Information
Note: This backend PR addresses a bug where the vector index appears even without the
--experimental-vector-index
flag. This PR can proceed with a mention of the backend PR as an upstream dependency.