Skip to content

DuckDB: Add support for multiple TRIM arguments #1916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 2, 2025
Merged

DuckDB: Add support for multiple TRIM arguments #1916

merged 2 commits into from
Jul 2, 2025
+31 −2

Conversation

ryanschneider
Copy link
Contributor

Like BigQuery and Snowflake, DuckDB also supports the 2nd characters argument to TRIM: https://duckdb.org/docs/stable/sql/functions/text.html#trimstring-characters

  • DuckDB was added to the list of dialects potentially expecting a comma
  • test_duckdb_trim is basically a copy of test_bigquery_trim using the proper dialect
  • parse_trim test was updated to exclude DuckDB alongside BigQuery and Snowflake.

iffyio
iffyio reviewed Jul 1, 2025
View reviewed changes
@ryanschneider ryanschneider requested a review from iffyio July 1, 2025 21:43
iffyio
iffyio approved these changes Jul 2, 2025
View reviewed changes
Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @ryanschneider!
cc @alamb

@iffyio iffyio changed the title fix: DuckDB accepts 2nd characters argument to TRIM DuckDB: Add support for multiple TRIM arguments Jul 2, 2025
@iffyio iffyio merged commit a339822 into apache:main Jul 2, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iffyio iffyio iffyio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanschneider @iffyio