Skip to content

Support for Postgres's CREATE SERVER #1914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Support for Postgres's CREATE SERVER #1914

wants to merge 12 commits into from
+196 −0

Conversation

solontsev
Copy link
Contributor

Closes #1814

@solontsev solontsev marked this pull request as ready for review June 30, 2025 05:23
iffyio
iffyio reviewed Jul 1, 2025
View reviewed changes
src/ast/mod.rs Outdated
/// CREATE SERVER
/// ```
/// See [PostgreSQL](https://www.postgresql.org/docs/current/sql-createserver.html)
CreateServer {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For new statements we're moving away from using anonymous structs, here can we introduce a dedicated struct for this statement?

CreateServer(CreateServerStatement)

See Statement::Raise as an example

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the example! All done, ready to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iffyio iffyio iffyio left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Postgres CREATE SERVER can't be parsed
2 participants
@solontsev @iffyio