Skip to content

Support num_retries field in env var for GCP connection #8700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2020

Conversation

mik-laj
Copy link
Member

@mik-laj mik-laj commented May 4, 2020

Fix: #8659


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@mik-laj mik-laj added the provider:google Google (including GCP) related issues label May 4, 2020
@mik-laj
Copy link
Member Author

mik-laj commented May 4, 2020

CC: @michalslowikowski00 Can I ask for review?

@michalslowikowski00
Copy link
Contributor

Great as always 👍

@mik-laj mik-laj requested review from turbaszek and potiuk May 4, 2020 20:44
@mik-laj mik-laj merged commit 8d6f1aa into apache:master May 5, 2020
@mik-laj mik-laj deleted the issue-8659 branch May 5, 2020 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting num_retries for a google-cloud-platform using env variables breaks google tasks
3 participants