Skip to content

Add Google Ads list accounts operator #8007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2020
Merged

Add Google Ads list accounts operator #8007

merged 1 commit into from
Apr 2, 2020

Conversation

turbaszek
Copy link
Member

Issue link: WILL BE INSERTED BY boring-cyborg

Make sure to mark the boxes below before creating PR: [x]

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@boring-cyborg boring-cyborg bot added area:docs provider:google Google (including GCP) related issues labels Mar 30, 2020
@turbaszek turbaszek requested review from mik-laj and potiuk March 30, 2020 09:30
@codecov-io
Copy link

codecov-io commented Mar 30, 2020 •
edited
Loading

Codecov Report

Merging #8007 into master will decrease coverage by 0.75%.
The diff coverage is 79.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8007      +/-   ##
==========================================
- Coverage   87.18%   86.43%   -0.76%     
==========================================
  Files         933      933              
  Lines       45289    45335      +46     
==========================================
- Hits        39486    39185     -301     
- Misses       5803     6150     +347
Impacted Files Coverage Δ
airflow/providers/google/ads/hooks/ads.py 71.79% <58.33%> (-6.78%) ⬇️
...w/providers/google/ads/example_dags/example_ads.py 100.00% <100.00%> (ø)
airflow/providers/google/ads/operators/ads.py 95.08% <100.00%> (+2.77%) ⬆️
...flow/providers/apache/cassandra/hooks/cassandra.py 21.25% <0.00%> (-72.50%) ⬇️
...w/providers/apache/hive/operators/mysql_to_hive.py 35.84% <0.00%> (-64.16%) ⬇️
airflow/kubernetes/volume_mount.py 44.44% <0.00%> (-55.56%) ⬇️
airflow/providers/postgres/operators/postgres.py 47.82% <0.00%> (-52.18%) ⬇️
airflow/providers/redis/operators/redis_publish.py 50.00% <0.00%> (-50.00%) ⬇️
airflow/kubernetes/volume.py 52.94% <0.00%> (-47.06%) ⬇️
airflow/providers/mongo/sensors/mongo.py 53.33% <0.00%> (-46.67%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7790239...4acc8dd. Read the comment docs.

@turbaszek turbaszek force-pushed the add-google-ads-list-accounts-op branch from 4acc8dd to 2a867ff Compare March 30, 2020 11:23
@turbaszek turbaszek force-pushed the add-google-ads-list-accounts-op branch from 2a867ff to da06f97 Compare March 30, 2020 13:14
@turbaszek turbaszek merged commit ed2bc00 into apache:master Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potiuk potiuk potiuk approved these changes

@mik-laj mik-laj Awaiting requested review from mik-laj

Assignees
No one assigned
Labels
provider:google Google (including GCP) related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@turbaszek @codecov-io @potiuk