Fix SBOM commands to work for Airflow 2 #52591
Merged
+224
−92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Airflow 3 will need to be updated with package-json.lock but for now we are fixing the sbom command to work for Airflow 2 (and generate airflow 2.11 SBOMS. Changes: * passing --github-token parameter which might be helpful to not rate-limit GitHub calls * allowing to pass either `--airflow-site-archive-path` or `--airflow-root-path` depending where we want to generate sbom - it can be generated in `archive` folder directly (when we want to update historical data) or in the airflow source directory when we want to add SBOM to **just** generated documentation during the doc-building phase
eladkal
approved these changes
Jun 30, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jun 30, 2025
Airflow 3 will need to be updated with package-json.lock but for now we are fixing the sbom command to work for Airflow 2 (and generate airflow 2.11 SBOMS. Changes: * passing --github-token parameter which might be helpful to not rate-limit GitHub calls * allowing to pass either `--airflow-site-archive-path` or `--airflow-root-path` depending where we want to generate sbom - it can be generated in `archive` folder directly (when we want to update historical data) or in the airflow source directory when we want to add SBOM to **just** generated documentation during the doc-building phase (cherry picked from commit acea31e) Co-authored-by: Jarek Potiuk <[email protected]>
Backport successfully created: v3-0-test
|
|
thank you :) |
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jun 30, 2025
Airflow 3 will need to be updated with package-json.lock but for now we are fixing the sbom command to work for Airflow 2 (and generate airflow 2.11 SBOMS. Changes: * passing --github-token parameter which might be helpful to not rate-limit GitHub calls * allowing to pass either `--airflow-site-archive-path` or `--airflow-root-path` depending where we want to generate sbom - it can be generated in `archive` folder directly (when we want to update historical data) or in the airflow source directory when we want to add SBOM to **just** generated documentation during the doc-building phase (cherry picked from commit acea31e) Co-authored-by: Jarek Potiuk <[email protected]>
potiuk
added a commit
that referenced
this pull request
Jun 30, 2025
Airflow 3 will need to be updated with package-json.lock but for now we are fixing the sbom command to work for Airflow 2 (and generate airflow 2.11 SBOMS. Changes: * passing --github-token parameter which might be helpful to not rate-limit GitHub calls * allowing to pass either `--airflow-site-archive-path` or `--airflow-root-path` depending where we want to generate sbom - it can be generated in `archive` folder directly (when we want to update historical data) or in the airflow source directory when we want to add SBOM to **just** generated documentation during the doc-building phase (cherry picked from commit acea31e) Co-authored-by: Jarek Potiuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Airflow 3 will need to be updated with package-json.lock but for now we are fixing the sbom command to work for Airflow 2 (and generate airflow 2.11 SBOMS.
Changes:
passing --github-token parameter which might be helpful to not rate-limit GitHub calls
allowing to pass either
--airflow-site-archive-pathor--airflow-root-pathdepending where we want to generate sbom - it can be generated inarchivefolder directly (when we want to update historical data) or in the airflow source directory when we want to add SBOM to just generated documentation during the doc-building phase^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.