-
Notifications
You must be signed in to change notification settings - Fork 15.3k
Support pluginv2 views #52582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Support pluginv2 views #52582
Conversation
Fab static check is failing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -102,6 +102,7 @@ | |||
"dags": "Dags", | |||
"docs": "Docs", | |||
"home": "Home", | |||
"legacyFabViews": "Legacy FAB Views", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Text is a bit tight in the menu, can you change it to "Legacy Views"?
"legacyFabViews": "Legacy FAB Views", | |
"legacyFabViews": "Legacy Views", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See also screenshot above...
Add the ability to see Plugins
flask_app_builder_views
in Airflow 3.Basically if we detect any
flaks_app_builder_views
in the plugins, and that those views have a menu entry, (They are not direct access only) we will add a "Legacy FAB views" entry to plugins. This will map topluginsv2
and there we will see our views in the menu, with the ability to click on them.Unfortunately I don't think we can guess the view url with the current API information, so we cannot directly map to legacy views from the Airflow 3 plugin menu item.