Skip to content

Support pluginv2 views #52582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pierrejeambrun
Copy link
Member

Add the ability to see Plugins flask_app_builder_views in Airflow 3.

Basically if we detect any flaks_app_builder_views in the plugins, and that those views have a menu entry, (They are not direct access only) we will add a "Legacy FAB views" entry to plugins. This will map to pluginsv2 and there we will see our views in the menu, with the ability to click on them.

Unfortunately I don't think we can guess the view url with the current API information, so we cannot directly map to legacy views from the Airflow 3 plugin menu item.

Screenshot 2025-06-30 at 18 34 07
Screenshot 2025-06-30 at 18 34 17
Screenshot 2025-06-30 at 18 34 28

@bbovenzi bbovenzi added this to the Airflow 3.1.0 milestone Jun 30, 2025
@bbovenzi
Copy link
Contributor

Fab static check is failing

Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Legacy FAB is calling :-D
Tweaked a bit in the code and was able with this to make the Edge Plugin working in FAB. Not that I want to have this created again but a proof it is working!

image

@@ -102,6 +102,7 @@
"dags": "Dags",
"docs": "Docs",
"home": "Home",
"legacyFabViews": "Legacy FAB Views",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text is a bit tight in the menu, can you change it to "Legacy Views"?

Suggested change
"legacyFabViews": "Legacy FAB Views",
"legacyFabViews": "Legacy Views",

Copy link
Contributor

@jscheffl jscheffl Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also screenshot above...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants