Add the upgrade_sqlalchemy breeze flag to run tests with SQLA2
#52559
+200
−138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new flag, upgrade_sqlalchemy, to allow running tests with SQLA2 via breeze.
- Adds a new parameter in ShellParams and propagates the flag through various testing and developer commands.
- Updates command configurations and option definitions to support the new flag.
Reviewed Changes
Copilot reviewed 9 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| dev/breeze/src/airflow_breeze/params/shell_params.py | Introduced the upgrade_sqlalchemy parameter and added it to environment variable setup. |
| dev/breeze/src/airflow_breeze/commands/testing_commands_config.py | Added the new command-line option for SQLAlchemy upgrade in testing commands. |
| dev/breeze/src/airflow_breeze/commands/testing_commands.py | Propagated the upgrade_sqlalchemy flag through test command functions. |
| dev/breeze/src/airflow_breeze/commands/developer_commands_config.py | Included the upgrade_sqlalchemy option for developer commands configuration. |
| dev/breeze/src/airflow_breeze/commands/developer_commands.py | Integrated the new flag into shell and run command flows for developers. |
| dev/breeze/src/airflow_breeze/commands/common_options.py | Defined the click option for upgrade_sqlalchemy with a help description. |
| dev/breeze/doc/images/output_testing_providers-tests.txt | Updated output hash for providers test results. |
| dev/breeze/doc/images/output_testing_core-tests.txt | Updated output hash for core test results. |
| dev/breeze/doc/images/output_shell.txt | Updated output hash for shell command results. |
+ Fix some existing shellcheck violations
4cb162a to
a9e6077
Compare
potiuk
approved these changes
Jun 30, 2025
potiuk
approved these changes
Jun 30, 2025
Backport failed to create: v3-0-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker 57dc55c v3-0-testThis should apply the commit to the v3-0-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
potiuk
pushed a commit
to potiuk/airflow
that referenced
this pull request
Jun 30, 2025
+ Fix some existing shellcheck violations (cherry picked from commit 57dc55c)
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jun 30, 2025
+ Fix some existing shellcheck violations (cherry picked from commit 57dc55c) Co-authored-by: Dev-iL <[email protected]>
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jun 30, 2025
+ Fix some existing shellcheck violations (cherry picked from commit 57dc55c) Co-authored-by: Dev-iL <[email protected]>
potiuk
added a commit
that referenced
this pull request
Jun 30, 2025
+ Fix some existing shellcheck violations (cherry picked from commit 57dc55c) Co-authored-by: Dev-iL <[email protected]>
|
cool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking apart #52233 some more: this PR adds a flag to breeze that allows running tests with SQLA2.
After this is merged, it should be possible to run the SQLA2 tests locally with:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.