Skip to content

Filter only provided integration paths for breeze integration testing #52462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 29, 2025
Merged

Filter only provided integration paths for breeze integration testing #52462

merged 5 commits into from
Jun 29, 2025
+32 −17

Conversation

gopidesupavan
Copy link
Member

Currently we process all the paths even when we specify specific integration. its bit confusing, lets fitlerout only provided integration paths.

Example

before:
This is for ydb , but it processed all the paths.

image

After:

image

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added area:dev-tools backport-to-v3-0-test Mark PR with this label to backport to v3-0-test branch labels Jun 29, 2025
jscheffl
jscheffl approved these changes Jun 29, 2025
View reviewed changes
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I especially also prefer the dark mode after the change compared to the capture of light mode :-D
Joke apart... LGTM! Thanks!

potiuk
potiuk approved these changes Jun 29, 2025
View reviewed changes
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Yeah, it comes from old days where we had integration tests mixed with regular tests, and when we were riunning multiple integration tests in single test command - but indeed, when we have them nicely separated, we can do just that!

@potiuk
Copy link
Member

potiuk commented Jun 29, 2025

We just need to be EXTRA careful with such changes and look at the logs of the integration tests, to see that they were actually executed and not just green.

@gopidesupavan
Copy link
Member Author

We just need to be EXTRA careful with such changes and look at the logs of the integration tests, to see that they were actually executed and not just green.

Yeah correct, In CI except provided input integration rest all integrations tests skipped. as the integration environment is different :)

@gopidesupavan
Copy link
Member Author

Renamed integration type gremline to tinkerpop, to align with other providers.

@potiuk
Copy link
Member

potiuk commented Jun 29, 2025

Renamed integration type gremline to tinkerpop, to align with other providers.

Yeah. Those were the "extra-careful" things :)

@potiuk
Copy link
Member

potiuk commented Jun 29, 2025

I think also @integration markers should be updated .

@gopidesupavan
Copy link
Member Author

I think also @integration markers should be updated .

ah gotcha :) updated

@gopidesupavan
Copy link
Member Author

BTW its good that when we modify dev tools, running all tests :)

@potiuk
Copy link
Member

potiuk commented Jun 29, 2025

BTW its good that when we modify dev tools, running all tests :)

Yep. That is by design.

@gopidesupavan gopidesupavan merged commit 0c947b5 into apache:main Jun 29, 2025
101 checks passed
@gopidesupavan gopidesupavan deleted the filter-correct-integration-paths branch June 29, 2025 18:32
@github-actions GitHub Actions
Copy link

Backport failed to create: v3-0-test. View the failure log Run details

Status Branch Result
❌ v3-0-test Commit Link

You can attempt to backport this manually by running:

cherry_picker 0c947b5 v3-0-test

This should apply the commit to the v3-0-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

gopidesupavan added a commit to gopidesupavan/airflow that referenced this pull request Jun 29, 2025
@gopidesupavan
Filter only provided integration paths for breeze integration testing (…
1dde576 
…apache#52462)

* Filter only provided integration paths

* Fix tests

* Rename gremline integration name to tinkerpop

* Fix selective_checks test

* Update @integration pytest marker with tinkerpop
@gopidesupavan gopidesupavan mentioned this pull request Jun 29, 2025
Merged
@potiuk
Copy link
Member

potiuk commented Jun 29, 2025

No need to backport

potiuk pushed a commit that referenced this pull request Jun 29, 2025
@gopidesupavan
Filter only provided integration paths for breeze integration testing (…
fdd93fa 
…#52462) (#52491)

* Filter only provided integration paths

* Fix tests

* Rename gremline integration name to tinkerpop

* Fix selective_checks test

* Update @integration pytest marker with tinkerpop
@gopidesupavan
Copy link
Member Author

No need to backport

Yeah, but it changed few images and hash value, thought its better to backport to avoid if any future conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potiuk potiuk potiuk approved these changes

@jscheffl jscheffl jscheffl approved these changes

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@jedcunningham jedcunningham Awaiting requested review from jedcunningham jedcunningham is a code owner

@amoghrajesh amoghrajesh Awaiting requested review from amoghrajesh amoghrajesh is a code owner

@eladkal eladkal Awaiting requested review from eladkal

Assignees
No one assigned
Labels
area:dev-tools backport-to-v3-0-test Mark PR with this label to backport to v3-0-test branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gopidesupavan @potiuk @jscheffl