Remove old, unused generate SVG airflowctl pre-commit and fix width #52457
Conversation
fe141ac to
1ac0f8d
Compare
|
Also fixed column width |
1ac0f8d to
92af3eb
Compare
|
Had to do a bit more to make a "fixed' width now - regardless if run locally or in CI ... |
The command was duplicated - an old version of it was also defined using cli folder that does not exist any more. Also column width is fixed when generating the help files which will make it independent from where the generation is run.
92af3eb to
8b48e7a
Compare
|
@bugraoz93 -> now the help images will be fixed at "80" character long - this way no matter who generates them, hashes and images should be the same. BTW. Would not you like to add rich and rich-ctl to airflow-ctl ? The help output is way better if you do and with rich you can add so much better feedback with colors. |
Backport failed to create: v3-0-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker ae2d81f v3-0-testThis should apply the commit to the v3-0-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
Many thanks, Jarek, for this change! Just found time to answer properly. Indeed, I have plans to add rich and rich-ctl to the help output. I will first handle JSON output rather than datamodels and then will move on to help output to make it prettier :) |
The command was duplicated - an old version of it was also defined using cli folder that does not exist any more. Also column width is fixed when generating the help files which will make it independent from where the generation is run.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.