Skip to content

Add colors to go tests output in CI #52454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2025

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Jun 29, 2025


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added area:dev-tools backport-to-v3-0-test Mark PR with this label to backport to v3-0-test branch labels Jun 29, 2025
@potiuk
Copy link
Member Author

potiuk commented Jun 29, 2025

Much nicer:

Screenshot 2025-06-29 at 13 53 27

@potiuk potiuk merged commit d050c6b into apache:main Jun 29, 2025
85 checks passed
@potiuk potiuk deleted the add-colors-to-go-test-output branch June 29, 2025 11:54
@potiuk
Copy link
Member Author

potiuk commented Jun 29, 2025

cc: @amoghrajesh @aritra24

Copy link

Backport failed to create: v3-0-test. View the failure log Run details

Status Branch Result
v3-0-test Commit Link

You can attempt to backport this manually by running:

cherry_picker d050c6b v3-0-test

This should apply the commit to the v3-0-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

@potiuk
Copy link
Member Author

potiuk commented Jun 29, 2025

No cherry-picking needed.

@aritra24
Copy link
Collaborator

Oooo lovely! Makes it quite a bit clearer

@potiuk
Copy link
Member Author

potiuk commented Jun 29, 2025

Oooo lovely! Makes it quite a bit clearer

gotestsum has also other options -> you might check it out :)

@aritra24
Copy link
Collaborator

Yup! Definitely, definitely need to check it out

Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep gotestsum is nice! I was going to update it soon with:

gotestsum -f testname -- -coverprofile=cover.out ./...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools backport-to-v3-0-test Mark PR with this label to backport to v3-0-test branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants