Improve terminal handling for breeze commands #52452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
840c326 to
3a642fc
Compare
gopidesupavan
approved these changes
Jun 29, 2025
|
400 is a bit too long :) 
|
3a642fc to
4f50e06
Compare
60157d0 to
0ac1682
Compare
Console width has been hard-coded in CI commands, which often limited what was written in CI (Github action's CI does not have a terminal, nor terminal width so we allocate pseudo-terminal there) However when running breeze locally we should be able to use all terminal width. This PR: * increases length of CI terminal as we tend to have longer paths now after we moved stuff to subdirectories * only fixes terminal size on CI and leaves it None (auto) for local runs * adds --tty (default auto) to `breeze run` command to allow to use it both locally and in CI.
0ac1682 to
6d46aef
Compare
Backport failed to create: v3-0-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker 3347e03 v3-0-testThis should apply the commit to the v3-0-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jun 29, 2025
Console width has been hard-coded in CI commands, which often limited what was written in CI (Github action's CI does not have a terminal, nor terminal width so we allocate pseudo-terminal there) However when running breeze locally we should be able to use all terminal width. This PR: * increases length of CI terminal as we tend to have longer paths now after we moved stuff to subdirectories * only fixes terminal size on CI and leaves it None (auto) for local runs * adds --tty (default auto) to `breeze run` command to allow to use it both locally and in CI. (cherry picked from commit 3347e03) Co-authored-by: Jarek Potiuk <[email protected]>
potiuk
added a commit
that referenced
this pull request
Jun 29, 2025
…52456) Console width has been hard-coded in CI commands, which often limited what was written in CI (Github action's CI does not have a terminal, nor terminal width so we allocate pseudo-terminal there) However when running breeze locally we should be able to use all terminal width. This PR: * increases length of CI terminal as we tend to have longer paths now after we moved stuff to subdirectories * only fixes terminal size on CI and leaves it None (auto) for local runs * adds --tty (default auto) to `breeze run` command to allow to use it both locally and in CI. (cherry picked from commit 3347e03)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Console width has been hard-coded in CI commands, which often limited what was written in CI (Github action's CI does not have a terminal, nor terminal width so we allocate pseudo-terminal there) However when running breeze locally we should be
able to use all terminal width.
This PR:
breeze runcommand to allow to use it both locally and in CI.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.