Skip to content

Improve constraints updated version check script #52446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2025

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Jun 29, 2025

This script is now much nicer, and more useful:

  • it has been refactored and split into smaller methods
  • --verbose flag is added to help with diagnostics
  • the "regular" and "explain why" loops are now merged into a single loop
  • table is always printed now - even in "--explain-why" mode, we print the table as list of packages is being traversed and then "explain why" summary is printed at the end.
  • typing is added everywhere

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

This script is now much nicer, and more useful:

* it has been refactored and split into smaller methods
* --verbose flag is added to help with diagnostics
* the "regular" and "explain why" loops are now merged into a
  single loop
* table is always printed now - even in "--explain-why" mode, we
  print the table as list of packages is being traversed and then
  "explain why" summary is printed at the end.
* typing is added everywhere
@potiuk potiuk requested a review from eladkal June 29, 2025 09:50
@boring-cyborg boring-cyborg bot added area:dev-tools backport-to-v3-0-test Mark PR with this label to backport to v3-0-test branch labels Jun 29, 2025
@potiuk
Copy link
Member Author

potiuk commented Jun 29, 2025

This is what the script can produce now:

Screenshot 2025-06-29 at 11 51 30

@potiuk
Copy link
Member Author

potiuk commented Jun 29, 2025

Practically 100% vibe-coded :D

Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@eladkal eladkal removed the backport-to-v3-0-test Mark PR with this label to backport to v3-0-test branch label Jun 29, 2025
@potiuk potiuk merged commit a05b4de into apache:main Jun 29, 2025
99 checks passed
@potiuk potiuk deleted the improve-package-version-sscript branch June 29, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants