Skip to content

Make sure all test version imports come from tests_common #52425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Jun 28, 2025


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@potiuk potiuk added backport-to-v3-0-test Mark PR with this label to backport to v3-0-test branch and removed backport-to-v3-0-test Mark PR with this label to backport to v3-0-test branch labels Jun 28, 2025
@potiuk potiuk changed the title Make sure all test version imports come from test_common Make sure all test version imports come from tests_common Jun 28, 2025
@potiuk potiuk force-pushed the add-pre-commit-to-check-test-version-imports branch from f6d6c32 to 4a027f8 Compare June 28, 2025 20:53
@potiuk potiuk requested a review from amoghrajesh as a code owner June 28, 2025 20:53
Copy link
Member

@gopidesupavan gopidesupavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@potiuk potiuk merged commit 85640d3 into apache:main Jun 28, 2025
99 checks passed
@potiuk potiuk deleted the add-pre-commit-to-check-test-version-imports branch June 28, 2025 21:46
Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice beat me to it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants