Adding some intelligence to classifying provider commits #52407
Merged
+104
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
approved these changes
Jun 28, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jun 28, 2025
…52407) (cherry picked from commit bbe711e) Co-authored-by: Amogh Desai <[email protected]>
Backport successfully created: v3-0-test
|
potiuk
pushed a commit
that referenced
this pull request
Jun 28, 2025
…52407) (#52412) (cherry picked from commit bbe711e) Co-authored-by: Amogh Desai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some intelligence to classify things before hand for trivial cases. I already had a
_is_test_or_example_dag_only_changesin place which did some of the work but not entirely.For example:
PR https://github.com/apache/airflow/pull/51107/files is included in tagging though it's only docs/tests
The PR linked above had
['providers/google/docs/operators/cloud/kubernetes_engine.rst', 'providers/google/tests/system/google/cloud/kubernetes_engine/example_kubernetes_engine_ray.py']which is doc and tests.
our current rules are:
which I guess is why we didn't catch the automation and asked RM to classify
So the idea here is to do this automatically. We check for precedence here, if docs and
test_or_exampleare present, docs has higher precedence.Overall precedence order is:
ask > doc-only > skip.
Added some tests that can help.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.