Skip to content

Replace models.BaseOperator to Task SDK one for Apache TinkerPop #52400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 29, 2025
Merged

Replace models.BaseOperator to Task SDK one for Apache TinkerPop #52400

merged 6 commits into from
Jun 29, 2025
+39 −1

Conversation

ahmadtfarhan
Copy link
Contributor

Follow-up of #52292 for Apache TinkerPop

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@ahmadtfarhan ahmadtfarhan mentioned this pull request Jun 28, 2025
Open
97 tasks
@kaxil kaxil force-pushed the apache-tinkerpop-change-baseoperator branch from a56410a to 9efd044 Compare June 28, 2025 10:51
@kaxil
Copy link
Member

kaxil commented Jun 28, 2025

One test failure:

FAILED airflow-core/tests/unit/always/test_project_structure.py::TestProjectStructure::test_providers_modules_should_have_tests - AssertionError: Detect missing tests in providers module - please add tests
assert equals failed
  [                                []                              
    'providers/apache/tinkerpop/t                                  
  ests/unit/apache/tinkerpop/test                                  
  _version_compat.py',                                             
  ]
===== 1 failed, 189 passed, 1356 skipped, 1 xfailed, 5 warnings in 45.65s ======

Add it similar to

airflow/airflow-core/tests/unit/always/test_project_structure.py

Line 98 in 9140bd6

"providers/arangodb/tests/unit/arangodb/test_version_compat.py",

@ahmadtfarhan
Copy link
Contributor Author

Done

@kaxil kaxil merged commit 50e69ab into apache:main Jun 29, 2025
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaxil kaxil kaxil approved these changes

Assignees
No one assigned
Labels
area:providers provider:apache-tinkerpop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahmadtfarhan @kaxil