Refactor Databricks hook to use HTTP method constants and auto-prepend api/ to endpoint paths #52385
+45
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c22885a to
f14013d
Compare
kyungjunleeme
commented
Jun 29, 2025
Comment on lines
+59
to
+61
| UPDATE_REPO_ENDPOINT = ("PATCH", "2.0/repos/") | ||
| DELETE_REPO_ENDPOINT = ("DELETE", "2.0/repos/") | ||
| CREATE_REPO_ENDPOINT = ("POST", "2.0/repos") |
There was a problem hiding this comment.
This time, I made new endpoint from method. I just wantt to notify
|
@jroachgolf84 Hello, Colud you review my pr? Thank in advance |
f14013d to
7c17536
Compare
7c17536 to
bd4af77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #52275.
It refactors the Databricks hook to:
I removed the hardcoded 'api/' prefix and added three new endpoints.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.