-
Notifications
You must be signed in to change notification settings - Fork 15.2k
Fix Airflow pin images for fab provider #52351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Airflow pin images for fab provider #52351
Conversation
Yep - needs asset regeneration. |
Weird, locally |
9723eda
to
c9395c9
Compare
Well CI still not happy. I'll put the hash that the CI wants to see (for reasons I don't understand) because this isn't what my local precommit is giving me when running that only hook. |
Strange .. let me see. |
It could be that you have some files that are .gitignored and different locally in "providers" / "fab" / "src" / "airflow" / "providers" / "fab" / "www" ? |
|
|
There is a very slim chance that SORTING order is different on your machine
This is how we calculate the hash - and sorting matters ,,, Maybe there are names that are sorted differently in FRENCH :D ? |
Can you also run this:
|
I also have
This is enormous for me. I had to truncate it (more than 80% I think I truncated, and everything was coming from node_modules, I left a bunch just to display as an example but this node_modules part seems really different from you)
|
Even after removing my local dist folder, still red. Something weird must be happening locally. I'll take a look later. |
As part of AIP-68, and backward compatibility for legacy plugins, I realized that those were missing. (Fab views have their own static folder, pins need to be available there).
Before
After