Replace models.BaseOperator to Task SDK one for Slack Provider #52347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c853e53 to
8f88a88
Compare
97 tasks
jscheffl
reviewed
Jun 29, 2025
Comment on lines
+24
to
+29
| from airflow.providers.slack.version_compat import AIRFLOW_V_3_0_PLUS | ||
|
|
||
| if AIRFLOW_V_3_0_PLUS: | ||
| from airflow.sdk import BaseOperator | ||
| else: | ||
| from airflow.models import BaseOperator |
There was a problem hiding this comment.
The idea was that the (redundant) selection of where to get BaseOperator from is moved to version_compat.py such that the few lines of boilerplate are in one place. Then you can import directly from there.
There was a problem hiding this comment.
Mhm, you have unresolved but when I take a look it is still the same.
Target is that:
- version_compat import the BaseOperator with the version qualifier
- All operators in the provider import BaseOperator from version_compat (so do not need a version switch logic)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Providers should use the BaseOperator from Task SDK for Airflow 3.0+.
Related: #52292
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.