feat: Add new documentation facet to all OL events #52343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ff0b151 to
ab813e2
Compare
ab813e2 to
4a05014
Compare
|
Rebasing to check compatibility after fixing it in main. |
4a05014 to
ca65519
Compare
ca65519 to
da97110
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ContentType was added to OL documentation job facet in #3748. OL client requirement was bumped in #52075 to include that change.
Now I'm adding a documentation facet to all OL events, with this new content type field.
We're checking all the fields mentioned in this doc: doc, doc_md etc.
This also introduce hierarchy, as we can only include one doc in the facet.
The order for task is the following:
docdoc_mddoc_jsondoc_yamldoc_rstFor DAG it's:
doc_mddescriptionAlso for tasks if task doc is not present, we're including DAG docs (if present).
Most of the lines is from testing it properly in system tests.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.