-
Notifications
You must be signed in to change notification settings - Fork 15.2k
[RFC] Feat(ui): Add portuguese translation + CODEOWNER #52341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
cc @victoru2 will help me on checking the PR. I checked before with some of my workmates. To take in account that this portuguese translation is from Portugal and not the Brazilian one that has some small differences on wordings. |
@@ -43,6 +43,7 @@ airflow-core/src/airflow/ui/public/i18n/locales/de/ @jscheffl # + @TJaniF @m1rac | |||
airflow-core/src/airflow/ui/public/i18n/locales/he/ @eladkal @shahar1 @romsharon98 # +@Dev-iL | |||
airflow-core/src/airflow/ui/public/i18n/locales/nl/ @BasPH # + @DjVinnii | |||
airflow-core/src/airflow/ui/public/i18n/locales/pl/ @potiuk @mobuchowski # + @kacpermuda | |||
airflow-core/src/airflow/ui/public/i18n/locales/pt/ @bbovenzi # + @aoelvp94 @victoru2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't be the codeowner as I don't know portuguese. We should post in the community to ask for reviews and see if someone can be the code owner.
"Connections": "Conexões", | ||
"Plugins": "Plugins", | ||
"Pools": "Pools", | ||
"Providers": "Fornecedores", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Providers": "Fornecedores", | |
"Providers": "Providers", |
I think I would keep "Providers" here.
"stats": "Estatísticas" | ||
}, | ||
"uri": "URI", | ||
"welcome": "Bem-vindo" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@victoru2 something more inclusive here my friend?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, all done here my friend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe Te damos as boas-vindas
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say Seja bem-vindo
😄
airflow-core/src/airflow/ui/public/i18n/locales/pt/components.json
Outdated
Show resolved
Hide resolved
…json Co-authored-by: Victor Urquiola <[email protected]>
Co-authored-by: Victor Urquiola <[email protected]>
Co-authored-by: Victor Urquiola <[email protected]>
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in airflow-core/newsfragments.