Skip to content

Set prefix to generate correctly the FAB Auth Manager API ref #52329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 30, 2025
Merged

Set prefix to generate correctly the FAB Auth Manager API ref #52329

merged 9 commits into from
Jun 30, 2025
+5 −3

Conversation

jpizquierdo
Copy link
Contributor

@jpizquierdo jpizquierdo commented Jun 27, 2025 •
edited
Loading

Set prefix to generate correctly the documentation because it is a FastAPI subapplication of the main one mounted in /auth, it will fix #52277

@jpizquierdo
set prefix to generate correctly the documentation because it is a Fa…
3cd98ce 
…stAPI subapplication of the main one mounted in /auth
@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented Jun 27, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@boring-cyborg boring-cyborg bot added area:dev-tools backport-to-v3-0-test Mark PR with this label to backport to v3-0-test branch labels Jun 27, 2025
@jpizquierdo
Copy link
Contributor Author

I would appreciate help testing this because I think work is made in the CI/CD environment

@jpizquierdo jpizquierdo mentioned this pull request Jun 27, 2025
Closed
2 tasks
vincbeck
vincbeck approved these changes Jun 27, 2025
View reviewed changes
Copy link
Contributor

@vincbeck vincbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vincbeck
Copy link
Contributor

Please run pre-commits, it will automatically fix the tests

@vincbeck
Copy link
Contributor

Documentation on how to run these pre-commits: https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst

@jpizquierdo
Copy link
Contributor Author

Documentation on how to run these pre-commits: https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst

Perfect! Thanks for the guidance, I will do it during the weekend

@jpizquierdo
Copy link
Contributor Author

I think that now I am done, thanks @vincbeck and @potiuk for the advises and guidance via github / slack

@vincbeck
Copy link
Contributor

Yep this is good! Thank you! And congrats with your first contribution :) I hope to see other PRs from you in the future :)

@vincbeck vincbeck merged commit 921221b into apache:main Jun 30, 2025
101 checks passed
@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented Jun 30, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

github-actions bot pushed a commit that referenced this pull request Jun 30, 2025
@jpizquierdo
[v3-0-test] Set prefix to generate correctly the FAB Auth Manager API…
62b2249 
… ref (#52329)

* set prefix to generate correctly the documentation because it is a FastAPI subapplication of the main one mounted in /auth

* autogenerated openapi yaml file generated by pre-commits
(cherry picked from commit 921221b)

Co-authored-by: Joel Pérez Izquierdo <[email protected]>
@github-actions GitHub Actions
Copy link

Backport successfully created: v3-0-test

Status Branch Result
✅ v3-0-test PR Link

github-actions bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Jun 30, 2025
@jpizquierdo
[v3-0-test] Set prefix to generate correctly the FAB Auth Manager API…
a1be425 
… ref (apache#52329)

* set prefix to generate correctly the documentation because it is a FastAPI subapplication of the main one mounted in /auth

* autogenerated openapi yaml file generated by pre-commits
(cherry picked from commit 921221b)

Co-authored-by: Joel Pérez Izquierdo <[email protected]>
@jpizquierdo jpizquierdo deleted the fix-fab-auth-manager-api-ref branch June 30, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincbeck vincbeck vincbeck approved these changes

@potiuk potiuk Awaiting requested review from potiuk potiuk is a code owner

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@gopidesupavan gopidesupavan Awaiting requested review from gopidesupavan gopidesupavan is a code owner

Assignees
No one assigned
Labels
area:dev-tools backport-to-v3-0-test Mark PR with this label to backport to v3-0-test branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong redoc auto documentation for FabAuthManager
2 participants
@jpizquierdo @vincbeck