Skip to content

Remove Legacy Query Object Usage from airflow-models #52325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Prab-27
Copy link
Contributor

@Prab-27 Prab-27 commented Jun 27, 2025

Related discussion: here

This PR is part of the migration to SQLAlchemy 2.0

Replaced instances of session.query() with select() constructs
Updated methods like XComModel.get_many to return Select objects instead of Query objects
Adjusted dependent code to reflect the updated return types


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

Copy link
Member

@jason810496 jason810496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could you help to make the CI green?

@Prab-27
Copy link
Contributor Author

Prab-27 commented Jun 30, 2025

Converting into draft until green checks

@Prab-27 Prab-27 marked this pull request as draft June 30, 2025 14:39
@Prab-27 Prab-27 force-pushed the remove-session-query-from-airflow-models branch from 67e0627 to bc302b0 Compare June 30, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants