-
Notifications
You must be signed in to change notification settings - Fork 15.2k
[RFC] Feat (ui): Add spanish translation + Spanish lang codeowner #52316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for the PR! Can’t review the Spanish translation, just a remark from me.
Really cool :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this started!
Would definitely appreciate a review by some other native speakers. I am not confident on when to borrow words from english or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall very good. 1 typo, otherwise minor things.
airflow-core/src/airflow/ui/public/i18n/locales/es/components.json
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/ui/public/i18n/locales/es/components.json
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/ui/public/i18n/locales/es/components.json
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/ui/public/i18n/locales/es/dashboard.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @aoelvp94 . This looks really good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
5573c4a
to
495549f
Compare
Co-authored-by: Jens Scheffler <[email protected]>
495549f
to
0e70f20
Compare
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in airflow-core/newsfragments.