Skip to content

Python versions in shell params are strings #52306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Jun 26, 2025

The versions were "floats" and it accidentally worked because they were coerced to strings, but with 3.10 it will be coerced to the "3.1" string.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

The versions were "floats" and it accidentally worked because
they were coerced to strings, but with 3.10 it will be coerced to
the "3.1" string.
@boring-cyborg boring-cyborg bot added area:dev-tools backport-to-v3-0-test Mark PR with this label to backport to v3-0-test branch labels Jun 26, 2025
@potiuk potiuk requested a review from eladkal June 26, 2025 20:39
@potiuk potiuk merged commit 1c0c01d into apache:main Jun 26, 2025
84 of 85 checks passed
@potiuk potiuk deleted the change-python-versions-to-string branch June 26, 2025 20:47
github-actions bot pushed a commit that referenced this pull request Jun 26, 2025
The versions were "floats" and it accidentally worked because
they were coerced to strings, but with 3.10 it will be coerced to
the "3.1" string.
(cherry picked from commit 1c0c01d)

Co-authored-by: Jarek Potiuk <[email protected]>
Copy link

Backport successfully created: v3-0-test

Status Branch Result
v3-0-test PR Link

github-actions bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Jun 26, 2025
The versions were "floats" and it accidentally worked because
they were coerced to strings, but with 3.10 it will be coerced to
the "3.1" string.
(cherry picked from commit 1c0c01d)

Co-authored-by: Jarek Potiuk <[email protected]>
potiuk added a commit that referenced this pull request Jun 26, 2025
)

The versions were "floats" and it accidentally worked because
they were coerced to strings, but with 3.10 it will be coerced to
the "3.1" string.
(cherry picked from commit 1c0c01d)

Co-authored-by: Jarek Potiuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools backport-to-v3-0-test Mark PR with this label to backport to v3-0-test branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants