Skip to content

Remove pre-commit check-daysago-import-from-utils #52304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 26, 2025
Merged

Remove pre-commit check-daysago-import-from-utils #52304

merged 2 commits into from
Jun 26, 2025

Conversation

eladkal
Copy link
Contributor

@eladkal eladkal commented Jun 26, 2025

We no longer have daysago function thus no need to validate we don't import it.

@boring-cyborg boring-cyborg bot added area:dev-tools backport-to-v3-0-test Mark PR with this label to backport to v3-0-test branch labels Jun 26, 2025
@eladkal eladkal added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jun 26, 2025
@eladkal eladkal removed the backport-to-v3-0-test Mark PR with this label to backport to v3-0-test branch label Jun 26, 2025
@eladkal
Copy link
Contributor Author

eladkal commented Jun 26, 2025

Test failure is not related to this change. merging

@eladkal eladkal merged commit 9c7c72c into apache:main Jun 26, 2025
95 of 96 checks passed
@eladkal eladkal deleted the days branch June 26, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potiuk potiuk potiuk approved these changes

@hussein-awala hussein-awala hussein-awala approved these changes

@gopidesupavan gopidesupavan gopidesupavan approved these changes

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@jedcunningham jedcunningham Awaiting requested review from jedcunningham jedcunningham is a code owner

@amoghrajesh amoghrajesh Awaiting requested review from amoghrajesh amoghrajesh is a code owner

Assignees
No one assigned
Labels
area:dev-tools changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eladkal @potiuk @hussein-awala @gopidesupavan