Skip to content

Use BaseSensorOperator from task sdk in providers #52296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gopidesupavan
Copy link
Member

@gopidesupavan gopidesupavan commented Jun 26, 2025

Now we have BaseSensorOperator in task sdk, we can use it from there.

Updated all the provider sensor references with task-sdk.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@gopidesupavan
Copy link
Member Author

gopidesupavan commented Jun 26, 2025

The changes are very small related single import , thats the reason i pulled everything to one PR, if anyone feels it needs to be separate PR for each provider, happy to split them or will create issue to then community can work.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good as is. The other "per-provider" changes were much more involved - and required more manual check - but this one is way better as a single PR.

Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gopidesupavan there is no need to add version-compat to the providers that are missing it, you can just import from from tests_common.test_utils.version_compat import AIRFLOW_V_3_0_PLUS

Apart from that it looks pretty good.

@gopidesupavan
Copy link
Member Author

@gopidesupavan there is no need to add version-compat to the providers that are missing it, you can just import from from tests_common.test_utils.version_compat import AIRFLOW_V_3_0_PLUS

Apart from that it looks pretty good.

No, i donth think tests_common is part of final package and also wouldnt use that import from tests_commn because its for tests.

@gopidesupavan gopidesupavan force-pushed the replace-basesensor-operator-imports-from-sdk branch from 0c2348a to 87e1fa5 Compare June 27, 2025 07:34
@gopidesupavan
Copy link
Member Author

@gopidesupavan there is no need to add version-compat to the providers that are missing it, you can just import from from tests_common.test_utils.version_compat import AIRFLOW_V_3_0_PLUS
Apart from that it looks pretty good.

No, i donth think tests_common is part of final package and also wouldnt use that import from tests_commn because its for tests.

BTW you raised good point we can refactor all the provider tests with imports from test_utils :)

@gopidesupavan gopidesupavan merged commit 266c1ce into apache:main Jun 27, 2025
99 checks passed
@gopidesupavan gopidesupavan deleted the replace-basesensor-operator-imports-from-sdk branch June 27, 2025 10:29
@kaxil
Copy link
Member

kaxil commented Jun 27, 2025

Looks good,

@gopidesupavan
Copy link
Member Author

Looks good,

cool, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants