-
Notifications
You must be signed in to change notification settings - Fork 15.3k
Use BaseSensorOperator from task sdk in providers #52296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use BaseSensorOperator from task sdk in providers #52296
Conversation
The changes are very small related single import , thats the reason i pulled everything to one PR, if anyone feels it needs to be separate PR for each provider, happy to split them or will create issue to then community can work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good as is. The other "per-provider" changes were much more involved - and required more manual check - but this one is way better as a single PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gopidesupavan there is no need to add version-compat
to the providers that are missing it, you can just import from from tests_common.test_utils.version_compat import AIRFLOW_V_3_0_PLUS
Apart from that it looks pretty good.
No, i donth think tests_common is part of final package and also wouldnt use that import from tests_commn because its for tests. |
0c2348a
to
87e1fa5
Compare
BTW you raised good point we can refactor all the provider tests with imports from test_utils :) |
Looks good, |
cool, thanks :) |
Now we have
BaseSensorOperator
in task sdk, we can use it from there.Updated all the provider sensor references with task-sdk.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in airflow-core/newsfragments.