-
Notifications
You must be signed in to change notification settings - Fork 15.2k
Enable LDAP users to generate an Airflow token with FabAuthManager
#52295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks @vincbeck ! I have tested this modification on my Helm Chart installed image based on By applying this modification, I firstly got a 500 Internal Server Error:
and then I modified the login.py and override.py by adding the rotate_session_id=False also to
Also FYI, here is my test image.
and this is the sever config in my helm chat values.yaml (If it is recommended, I can start another issue to decribe this) I was using a third-party airflow helm chart on Airflow 2.* but currently using the official Helm Chart 1.17 this time. I notice that the webServer section in official chart seems not being used at all, only apiServer got used (not sure if it is the expected behavior). For example, no
Contact me if you need any futher information! |
tested with airflow python 3.12 and all default dependencies. Same error:
|
Thank you to both of you for testing it! Very much appreciated it. And thank you @yanshil for suggesting a fix. You're actually right, I missed that but |
570cfd2
to
cc144cb
Compare
Hi @vincbeck , I have setup a local api-server with LDAP. Everything works fine from myside. Will try a full docker compose setup now to see if there is any persistence issue
From LDAP server:
|
Tested and working over here with latest helmchart, thanks |
I think we need some doc entries leting users know about this option and how to configure it |
Sounds good |
cc144cb
to
a17d236
Compare
Done :) |
Resolves #52103.
Today only users stored in DB can generate an Airflow JWT token in order to access Airflow API. This PRs adds capability for LDAP users to also generate a token.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in airflow-core/newsfragments.